-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vMix): add vMix input layers props and commands #331
feat(vMix): add vMix input layers props and commands #331
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #331 +/- ##
==========================================
+ Coverage 37.58% 38.01% +0.43%
==========================================
Files 106 106
Lines 10247 10309 +62
Branches 2452 2481 +29
==========================================
+ Hits 3851 3919 +68
+ Misses 6395 6389 -6
Partials 1 1 ☔ View full report in Codecov by Sentry. |
@@ -136,7 +138,7 @@ export class VMixTimelineStateConverter { | |||
loop: content.loop, | |||
position: content.seek, | |||
transform: content.transform, | |||
overlays: content.overlays, | |||
layers: content.overlays ? this._convertDeprecatedInputOverlays(content.overlays) : content.layers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are filling in both overlays and layers, it would be preferred to look at the layers property. The current behaviour is acceptable but should be documented as such.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the behavior as suggested, and updated the code comment, so that there's no doubt
@mint-dewit, after merging to release51, this doesn't seem to pass linting and test. Will you look into it, or shall I? |
They should be OK now! |
About the Contributor
This PR is opened on behalf of TV 2 Norge.
Type of Contribution
This is a:
Feature
Current Behavior
Layer properties that can be set through the API since vMix 27 are not supported.
New Behavior
Introduces
layers
property onTimelineContentVMixInput
. Deprecates theoverlays
(still functional).The following properties/commands are now supported:
panX
-SetLayer[1...10]PanX
panY
-SetLayer[1...10]PanY
zoom
-SetLayer[1...10]Zoom
cropLeft
,cropTop
,cropRight
,cropBottom
-SetLayer[1...10]Crop
Testing Instructions
Other Information
Status