OBS refactoring (Sofie 2486) #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nytamin
approved these changes
Jan 8, 2024
| import _ = require('underscore') | ||
| import { OBSCommandWithContext, OBSCommandWithContextTyped } from '.' | ||
| import { OBSDeviceState, OBSScene, OBSSceneItem, OBSInputState } from './state' | ||
| import { OBSRequest as OBSRequestName } from 'timeline-state-resolver-types' |
There was a problem hiding this comment.
This rename is unnecessary (?)
| @@ -1,35 +1,43 @@ | |||
| import { DeviceType } from '..' | |||
|
|
|||
| export enum OBSRequest { | |||
There was a problem hiding this comment.
This enum is only ever used in TSR, not externally. So we could move it into the TSR package instead.
(
While we're at it, add this comment as well:
/** values are derived from keyof OBSRequestTypes in obs-websocket-js */
)
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release51 #316 +/- ##
=============================================
+ Coverage 46.76% 48.59% +1.82%
=============================================
Files 110 113 +3
Lines 9956 9991 +35
Branches 2450 2478 +28
=============================================
+ Hits 4656 4855 +199
+ Misses 4823 4685 -138
+ Partials 477 451 -26 ☔ View full report in Codecov by Sentry. |
mint-dewit
force-pushed
the
SOFIE-2486-obs-refactoring
branch
from
4a3a4e9 to
2c20d0b
Compare
This reverts commit bcd87a6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently using a github repo instead of the NPM package awaiting this PR obs-websocket-community-projects/obs-websocket-js#347