-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP-server: Add '/list' endpoint #191
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a bit weird that listPackages
both has a side-effect and returns a value, but I suppose that makes it simpler.
I think however that it would be helpful if the href's in the HTML page would be relative, since that will be easier on reverse-proxies (if any) in front of PM HTTP server.
…explicitly return their data instead of modifying ctx directly
Agreed, it became quite hard to understand what's happening.. I've refactored the http-server now so that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is much cleaner now!
Just some minor naming feedback, and a question if we really need packageVersion.ts
to be committed to the repo.
About Me
This pull request is posted on behalf of the NRK
Type of Contribution
This is a:
Feature
Current Behavior
The only way to see which files are hosted by http-server is the JSON exposed at
/packages
New Behavior
New page at
/list
which displays a list of the files in a user(-ish) friendly way.Testing Instructions
Other Information
Status