Skip to content

Commit

Permalink
fix: revert feat: switch from eslint-plugin-node to eslint-plugin-n [7…
Browse files Browse the repository at this point in the history 
…22cad9]

The eslint-plugin-n change would be quite breaking for consumers, I talked to @Julusian about this just now and we'll revert this change for now and put the change as breaking in a future PR.
  • Loading branch information
@nytamin
nytamin committed Aug 9, 2023
1 parent 450c451 commit 617f100
Show file tree
Hide file tree
Showing 4 changed files with 114 additions and 66 deletions.
6 changes: 3 additions & 3 deletions eslint/fragments.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ module.exports = {

commonExtends: [
'eslint:recommended',
'plugin:n/recommended',
'plugin:node/recommended',
'plugin:jest/recommended',
'plugin:prettier/recommended',
'plugin:@sofie-automation/all',
Expand All @@ -14,7 +14,7 @@ module.exports = {
'plugin:@typescript-eslint/eslint-recommended',
'plugin:@typescript-eslint/recommended',
'plugin:@typescript-eslint/recommended-requiring-type-checking',
'plugin:n/recommended',
'plugin:node/recommended',
'plugin:jest/recommended',
'prettier',
'plugin:prettier/recommended',
Expand All @@ -24,7 +24,7 @@ module.exports = {
'prettier/prettier': 'error',
'no-unused-vars': ['error', { argsIgnorePattern: '^_', varsIgnorePattern: '^_(.+)' }],
'no-extra-semi': 'off',
'n/no-unsupported-features/es-syntax': ['error', { ignores: ['modules'] }],
'node/no-unsupported-features/es-syntax': ['error', { ignores: ['modules'] }],
'no-use-before-define': 'off',
'no-warning-comments': ['error', { terms: ['nocommit', '@nocommit', '@no-commit'] }],
'jest/no-mocks-import': 'off',
Expand Down
2 changes: 1 addition & 1 deletion eslint/main.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ module.exports = {
...commonRules,
...tsRules,
'no-process-exit': 'off',
'n/no-missing-import': 'off',
'node/no-missing-import': 'off',
},
},
],
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"eslint": "^8.42.0",
"eslint-config-prettier": "^8.8.0",
"eslint-plugin-jest": "^27.2.1",
"eslint-plugin-n": "^16.0.0",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-prettier": "^4.2.1",
"husky": "^8.0.3",
"license-checker": "^25.0.1",
Expand Down
170 changes: 109 additions & 61 deletions yarn.lock
View file
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ __metadata:
languageName: node
linkType: hard

"@eslint-community/eslint-utils@npm:^4.1.2, @eslint-community/eslint-utils@npm:^4.2.0, @eslint-community/eslint-utils@npm:^4.4.0":
"@eslint-community/eslint-utils@npm:^4.2.0":
version: 4.4.0
resolution: "@eslint-community/eslint-utils@npm:4.4.0"
dependencies:
Expand All @@ -52,27 +52,27 @@ __metadata:
languageName: node
linkType: hard

"@eslint-community/regexpp@npm:^4.4.0, @eslint-community/regexpp@npm:^4.5.0":
version: 4.5.1
resolution: "@eslint-community/regexpp@npm:4.5.1"
checksum: 6d901166d64998d591fab4db1c2f872981ccd5f6fe066a1ad0a93d4e11855ecae6bfb76660869a469563e8882d4307228cebd41142adb409d182f2966771e57e
"@eslint-community/regexpp@npm:^4.4.0":
version: 4.5.0
resolution: "@eslint-community/regexpp@npm:4.5.0"
checksum: 99c01335947dbd7f2129e954413067e217ccaa4e219fe0917b7d2bd96135789384b8fedbfb8eb09584d5130b27a7b876a7150ab7376f51b3a0c377d5ce026a10
languageName: node
linkType: hard

"@eslint/eslintrc@npm:^2.0.3":
version: 2.0.3
resolution: "@eslint/eslintrc@npm:2.0.3"
version: 2.1.1
resolution: "@eslint/eslintrc@npm:2.1.1"
dependencies:
ajv: ^6.12.4
debug: ^4.3.2
espree: ^9.5.2
espree: ^9.6.0
globals: ^13.19.0
ignore: ^5.2.0
import-fresh: ^3.2.1
js-yaml: ^4.1.0
minimatch: ^3.1.2
strip-json-comments: ^3.1.1
checksum: ddc51f25f8524d8231db9c9bf03177e503d941a332e8d5ce3b10b09241be4d5584a378a529a27a527586bfbccf3031ae539eb891352033c340b012b4d0c81d92
checksum: bf909ea183d27238c257a82d4ffdec38ca94b906b4b8dfae02ecbe7ecc9e5a8182ef5e469c808bb8cb4fea4750f43ac4ca7c4b4a167b6cd7e3aaacd386b2bd25
languageName: node
linkType: hard

Expand Down Expand Up @@ -147,7 +147,7 @@ __metadata:
eslint: ^8.42.0
eslint-config-prettier: ^8.8.0
eslint-plugin-jest: ^27.2.1
eslint-plugin-n: ^16.0.0
eslint-plugin-node: ^11.1.0
eslint-plugin-prettier: ^4.2.1
husky: ^8.0.3
license-checker: ^25.0.1
Expand Down Expand Up @@ -348,6 +348,15 @@ __metadata:
languageName: node
linkType: hard

"acorn@npm:^8.9.0":
version: 8.10.0
resolution: "acorn@npm:8.10.0"
bin:
acorn: bin/acorn
checksum: 538ba38af0cc9e5ef983aee196c4b8b4d87c0c94532334fa7e065b2c8a1f85863467bb774231aae91613fcda5e68740c15d97b1967ae3394d20faddddd8af61d
languageName: node
linkType: hard

"aggregate-error@npm:^3.0.0":
version: 3.1.0
resolution: "aggregate-error@npm:3.1.0"
Expand Down Expand Up @@ -486,15 +495,6 @@ __metadata:
languageName: node
linkType: hard

"builtins@npm:^5.0.1":
version: 5.0.1
resolution: "builtins@npm:5.0.1"
dependencies:
semver: ^7.0.0
checksum: 66d204657fe36522822a95b288943ad11b58f5eaede235b11d8c4edaa28ce4800087d44a2681524c340494aadb120a0068011acabe99d30e8f11a7d826d83515
languageName: node
linkType: hard

"callsites@npm:^3.0.0":
version: 3.1.0
resolution: "callsites@npm:3.1.0"
Expand Down Expand Up @@ -800,15 +800,15 @@ __metadata:
languageName: node
linkType: hard

"eslint-plugin-es-x@npm:^6.1.0":
version: 6.2.1
resolution: "eslint-plugin-es-x@npm:6.2.1"
"eslint-plugin-es@npm:^3.0.0":
version: 3.0.1
resolution: "eslint-plugin-es@npm:3.0.1"
dependencies:
"@eslint-community/eslint-utils": ^4.1.2
"@eslint-community/regexpp": ^4.5.0
eslint-utils: ^2.0.0
regexpp: ^3.0.0
peerDependencies:
eslint: ">=8"
checksum: 6104f6575b137e4ac9a2036c521bc8c3519ef3459287c55615bea69ea89b95712f7233dbb66f4006f07bcaabb2ec628ef76c47a6c7d6b5ab6056ee3fa38fe04f
eslint: ">=4.19.1"
checksum: e57592c52301ee8ddc296ae44216df007f3a870bcb3be8d1fbdb909a1d3a3efe3fa3785de02066f9eba1d6466b722d3eb3cc3f8b75b3cf6a1cbded31ac6298e4
languageName: node
linkType: hard

Expand All @@ -829,21 +829,19 @@ __metadata:
languageName: node
linkType: hard

"eslint-plugin-n@npm:^16.0.0":
version: 16.0.0
resolution: "eslint-plugin-n@npm:16.0.0"
"eslint-plugin-node@npm:^11.1.0":
version: 11.1.0
resolution: "eslint-plugin-node@npm:11.1.0"
dependencies:
"@eslint-community/eslint-utils": ^4.4.0
builtins: ^5.0.1
eslint-plugin-es-x: ^6.1.0
eslint-plugin-es: ^3.0.0
eslint-utils: ^2.0.0
ignore: ^5.1.1
is-core-module: ^2.12.0
minimatch: ^3.1.2
resolve: ^1.22.2
semver: ^7.5.0
minimatch: ^3.0.4
resolve: ^1.10.1
semver: ^6.1.0
peerDependencies:
eslint: ">=7.0.0"
checksum: 77bb74747ee021cd33d6027a1e13620a910a05755e42e29b4f810ef52800ae62bd21057c5e7de66dc3b8cbc9bc8332eeea4c9e14ed889284e549278d1520fe3e
eslint: ">=5.16.0"
checksum: 5804c4f8a6e721f183ef31d46fbe3b4e1265832f352810060e0502aeac7de034df83352fc88643b19641bb2163f2587f1bd4119aff0fd21e8d98c57c450e013b
languageName: node
linkType: hard

Expand Down Expand Up @@ -882,10 +880,33 @@ __metadata:
languageName: node
linkType: hard

"eslint-visitor-keys@npm:^3.3.0, eslint-visitor-keys@npm:^3.4.1":
version: 3.4.1
resolution: "eslint-visitor-keys@npm:3.4.1"
checksum: f05121d868202736b97de7d750847a328fcfa8593b031c95ea89425333db59676ac087fa905eba438d0a3c5769632f828187e0c1a0d271832a2153c1d3661c2c
"eslint-utils@npm:^2.0.0":
version: 2.1.0
resolution: "eslint-utils@npm:2.1.0"
dependencies:
eslint-visitor-keys: ^1.1.0
checksum: 27500938f348da42100d9e6ad03ae29b3de19ba757ae1a7f4a087bdcf83ac60949bbb54286492ca61fac1f5f3ac8692dd21537ce6214240bf95ad0122f24d71d
languageName: node
linkType: hard

"eslint-visitor-keys@npm:^1.1.0":
version: 1.3.0
resolution: "eslint-visitor-keys@npm:1.3.0"
checksum: 37a19b712f42f4c9027e8ba98c2b06031c17e0c0a4c696cd429bd9ee04eb43889c446f2cd545e1ff51bef9593fcec94ecd2c2ef89129fcbbf3adadbef520376a
languageName: node
linkType: hard

"eslint-visitor-keys@npm:^3.3.0":
version: 3.4.0
resolution: "eslint-visitor-keys@npm:3.4.0"
checksum: 33159169462d3989321a1ec1e9aaaf6a24cc403d5d347e9886d1b5bfe18ffa1be73bdc6203143a28a606b142b1af49787f33cff0d6d0813eb5f2e8d2e1a6043c
languageName: node
linkType: hard

"eslint-visitor-keys@npm:^3.4.1":
version: 3.4.2
resolution: "eslint-visitor-keys@npm:3.4.2"
checksum: 9e0e7e4aaea705c097ae37c97410e5f167d4d2193be2edcb1f0760762ede3df01545e4820ae314f42dcec687745f2c6dcaf6d83575c4a2a241eb0c8517d724f2
languageName: node
linkType: hard

Expand Down Expand Up @@ -949,6 +970,17 @@ __metadata:
languageName: node
linkType: hard

"espree@npm:^9.6.0":
version: 9.6.1
resolution: "espree@npm:9.6.1"
dependencies:
acorn: ^8.9.0
acorn-jsx: ^5.3.2
eslint-visitor-keys: ^3.4.1
checksum: eb8c149c7a2a77b3f33a5af80c10875c3abd65450f60b8af6db1bfcfa8f101e21c1e56a561c6dc13b848e18148d43469e7cd208506238554fb5395a9ea5a1ab9
languageName: node
linkType: hard

"esquery@npm:^1.4.2":
version: 1.5.0
resolution: "esquery@npm:1.5.0"
Expand Down Expand Up @@ -1340,12 +1372,12 @@ __metadata:
languageName: node
linkType: hard

"is-core-module@npm:^2.12.0, is-core-module@npm:^2.5.0, is-core-module@npm:^2.8.1":
version: 2.12.1
resolution: "is-core-module@npm:2.12.1"
"is-core-module@npm:^2.11.0, is-core-module@npm:^2.5.0, is-core-module@npm:^2.8.1":
version: 2.12.0
resolution: "is-core-module@npm:2.12.0"
dependencies:
has: ^1.0.3
checksum: f04ea30533b5e62764e7b2e049d3157dc0abd95ef44275b32489ea2081176ac9746ffb1cdb107445cf1ff0e0dfcad522726ca27c27ece64dadf3795428b8e468
checksum: f7f7eb2ab71fd769ee9fb2385c095d503aa4b5ce0028c04557de03f1e67a87c85e5bac1f215945fc3c955867a139a415a3ec4c4234a0bffdf715232660f440a6
languageName: node
linkType: hard

Expand Down Expand Up @@ -1680,7 +1712,7 @@ __metadata:
languageName: node
linkType: hard

"minimatch@npm:^3.0.5, minimatch@npm:^3.1.1, minimatch@npm:^3.1.2":
"minimatch@npm:^3.0.4, minimatch@npm:^3.0.5, minimatch@npm:^3.1.1, minimatch@npm:^3.1.2":
version: 3.1.2
resolution: "minimatch@npm:3.1.2"
dependencies:
Expand Down Expand Up @@ -2148,36 +2180,43 @@ __metadata:
languageName: node
linkType: hard

"regexpp@npm:^3.0.0":
version: 3.2.0
resolution: "regexpp@npm:3.2.0"
checksum: a78dc5c7158ad9ddcfe01aa9144f46e192ddbfa7b263895a70a5c6c73edd9ce85faf7c0430e59ac38839e1734e275b9c3de5c57ee3ab6edc0e0b1bdebefccef8
languageName: node
linkType: hard

"resolve-from@npm:^4.0.0":
version: 4.0.0
resolution: "resolve-from@npm:4.0.0"
checksum: f4ba0b8494846a5066328ad33ef8ac173801a51739eb4d63408c847da9a2e1c1de1e6cbbf72699211f3d13f8fc1325648b169bd15eb7da35688e30a5fb0e4a7f
languageName: node
linkType: hard

"resolve@npm:^1.10.0, resolve@npm:^1.22.2":
version: 1.22.3
resolution: "resolve@npm:1.22.3"
"resolve@npm:^1.10.0, resolve@npm:^1.10.1":
version: 1.22.2
resolution: "resolve@npm:1.22.2"
dependencies:
is-core-module: ^2.12.0
is-core-module: ^2.11.0
path-parse: ^1.0.7
supports-preserve-symlinks-flag: ^1.0.0
bin:
resolve: bin/resolve
checksum: fb834b81348428cb545ff1b828a72ea28feb5a97c026a1cf40aa1008352c72811ff4d4e71f2035273dc536dcfcae20c13604ba6283c612d70fa0b6e44519c374
checksum: 7e5df75796ebd429445d102d5824482ee7e567f0070b2b45897b29bb4f613dcbc262e0257b8aeedb3089330ccaea0d6a0464df1a77b2992cf331dcda0f4cb549
languageName: node
linkType: hard

"resolve@patch:resolve@^1.10.0#~builtin<compat/resolve>, resolve@patch:resolve@^1.22.2#~builtin<compat/resolve>":
version: 1.22.3
resolution: "resolve@patch:resolve@npm%3A1.22.3#~builtin<compat/resolve>::version=1.22.3&hash=c3c19d"
"resolve@patch:resolve@^1.10.0#~builtin<compat/resolve>, resolve@patch:resolve@^1.10.1#~builtin<compat/resolve>":
version: 1.22.2
resolution: "resolve@patch:resolve@npm%3A1.22.2#~builtin<compat/resolve>::version=1.22.2&hash=c3c19d"
dependencies:
is-core-module: ^2.12.0
is-core-module: ^2.11.0
path-parse: ^1.0.7
supports-preserve-symlinks-flag: ^1.0.0
bin:
resolve: bin/resolve
checksum: ad59734723b596d0891321c951592ed9015a77ce84907f89c9d9307dd0c06e11a67906a3e628c4cae143d3e44898603478af0ddeb2bba3f229a9373efe342665
checksum: 66cc788f13b8398de18eb4abb3aed90435c84bb8935953feafcf7231ba4cd191b2c10b4a87b1e9681afc34fb138c705f91f7330ff90bfa36f457e5584076a2b8
languageName: node
linkType: hard

Expand Down Expand Up @@ -2243,14 +2282,23 @@ __metadata:
languageName: node
linkType: hard

"semver@npm:^7.0.0, semver@npm:^7.3.4, semver@npm:^7.3.5, semver@npm:^7.3.7, semver@npm:^7.5.0, semver@npm:^7.5.2":
version: 7.5.2
resolution: "semver@npm:7.5.2"
"semver@npm:^6.1.0":
version: 6.3.0
resolution: "semver@npm:6.3.0"
bin:
semver: ./bin/semver.js
checksum: 1b26ecf6db9e8292dd90df4e781d91875c0dcc1b1909e70f5d12959a23c7eebb8f01ea581c00783bbee72ceeaad9505797c381756326073850dc36ed284b21b9
languageName: node
linkType: hard

"semver@npm:^7.3.4, semver@npm:^7.3.5, semver@npm:^7.3.7, semver@npm:^7.5.2":
version: 7.5.4
resolution: "semver@npm:7.5.4"
dependencies:
lru-cache: ^6.0.0
bin:
semver: bin/semver.js
checksum: 3fdf5d1e6f170fe8bcc41669e31787649af91af7f54f05c71d0865bb7aa27e8b92f68b3e6b582483e2c1c648008bc84249d2cd86301771fe5cbf7621d1fe5375
checksum: 12d8ad952fa353b0995bf180cdac205a4068b759a140e5d3c608317098b3575ac2f1e09182206bf2eb26120e1c0ed8fb92c48c592f6099680de56bb071423ca3
languageName: node
linkType: hard

Expand Down

0 comments on commit 617f100

Please sign in to comment.