Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nrk check radio #235

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Nrk check radio #235

merged 3 commits into from
Oct 4, 2023

Conversation

skjalgepalg
Copy link
Collaborator

Add new icon nrk-check-radio--unchecked

  • For use to imply input[type="radio"] functionality together with nrk-check--active
    • Name is adjusted to reflect this, open to input on how we can improve this
  • Expressive variant would be identical and has been kept out

resolves #233

@skjalgepalg skjalgepalg added enhancement semver:minor Involves added, backwards compatible, functionality labels Oct 4, 2023
@skjalgepalg skjalgepalg self-assigned this Oct 4, 2023
@skjalgepalg skjalgepalg merged commit 8f680fa into master Oct 4, 2023
1 check passed
@skjalgepalg skjalgepalg deleted the nrk-check-radio--unchecked branch October 4, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simenmyklebust simenmyklebust simenmyklebust approved these changes

@stefanogden stefanogden Awaiting requested review from stefanogden

@marve-svenningsen marve-svenningsen Awaiting requested review from marve-svenningsen

Assignees

@skjalgepalg skjalgepalg

Labels
enhancement semver:minor Involves added, backwards compatible, functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New icon: Check (radio-state)
2 participants
@skjalgepalg @simenmyklebust