Skip to content

Commit

Permalink
update chevron icons + add classname to svg string export (#116)
Browse files Browse the repository at this point in the history
  • Loading branch information
htor authored Dec 4, 2019
1 parent ef56f2d commit 9b8cbc1
Show file tree
Hide file tree
Showing 11 changed files with 86 additions and 75 deletions.
Binary file modified lib/core-icons.sketch
Binary file not shown.
1 change: 0 additions & 1 deletion lib/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
<li><a href="core-icons-svg.zip" download>Download SVG icons</a></li>
<li><a href="core-icons-pdf.zip" download>Download PDF icons</a></li>
<li><a href="https://github.com/nrkno/core-icons">View on Github</a></li>
<li><a href="https://github.com/nrkno/core-icons">View on Github</a></li>
<li><a href="https://github.com/nrkno/core-icons/releases">View changelog</a></li>
<li><a href="https://github.com/nrkno/core-icons/issues/new?title=Icon%20Request:%20&labels=enhancement">Request new icon</a></li>
<li><a href="https://nrk.slack.com/messages/C49CY4VTP/">Get help (NRK only)</a></li>
Expand Down
2 changes: 1 addition & 1 deletion lib/nrk-chevron-down.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion lib/nrk-chevron-left.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion lib/nrk-chevron-right.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion lib/nrk-chevron-up.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion lib/nrk-media-theater--active.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion lib/nrk-media-theater.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
48 changes: 24 additions & 24 deletions lib/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,30 @@

> Icon and logo kit providing a consistent and predictable user experience across platforms and NRK services
## Overview

Search for your icons in the search field below or download a ZIP file containing all icons in the left menu.

<!--demo
<style>
.doc-grid { overflow: hidden }
.doc-grid > * { box-sizing: border-box; display: inline-block; vertical-align: top; width: 33%; min-width: 300px; padding: 15px 15px 15px 0 }
.docs-icons > * { width: 16.6%; min-width: 120px }
.docs-icons > h3 { width: 100%; min-width: none; margin: 0 0 .5em; }
.docs-icons a, .docs-icons button { -webkit-appearance: none; font: inherit; background: none; color: inherit; border: 0; padding: 2px 0; text-decoration: underline; cursor: pointer; }
.doc-hidden { position: fixed; left: -300px; opacity: 0 }
.doc-input { font: inherit; color: inherit; margin-bottom: 2px; padding: 5px 9px; border: 1px solid #ccc; border-radius: 3px }
.doc-config { margin-bottom: 2em; }
</style>
<div class="doc-config doc-grid">
<input type="text" aria-hidden="true" tabindex="-1" id="docs-copy" class="doc-hidden">
<input type="text" class="doc-input" name="search" placeholder="Type to search" autocomplete="off" aria-label="Filter icons">
</div>
<div class="docs-icons doc-grid" style="padding:0 7vw;margin:0 -7vw;transition:.2s"></div>
<script src="core-icons.min.js"></script>
<script src="readme.js"></script>
demo-->

## Installation

[Download the Sketch library](sketch://add-library?url=https%3A%2F%2Fstatic.nrk.no%2Fcore-icons%2Flatest%2Fcore-icons.rss) for sketching, [SVGs](#icons) for Android, [PDFs](#icons) for iOS. All icons follow [BEM naming conventions](http://getbem.com/) and are prefixed with `nrk-` to play nice with existing code.
Expand Down Expand Up @@ -43,30 +67,6 @@ Scale the icons/logos by using font sizes divisible with `16` for sharpest rende

Note: correct width/height in `em` for each icon is automatically provided by `@nrk/core-icons`

## Icons

Search for your icons in the search field below or download a ZIP file containing all icons in the left menu.

<!--demo
<style>
.doc-grid { overflow: hidden }
.doc-grid > * { box-sizing: border-box; display: inline-block; vertical-align: top; width: 33%; min-width: 300px; padding: 15px 15px 15px 0 }
.docs-icons > * { width: 16.6%; min-width: 120px }
.docs-icons > h3 { width: 100%; min-width: none; margin: 0 0 .5em; }
.docs-icons a, .docs-icons button { -webkit-appearance: none; font: inherit; background: none; color: inherit; border: 0; padding: 2px 0; text-decoration: underline; cursor: pointer; }
.doc-hidden { position: fixed; left: -300px; opacity: 0 }
.doc-input { font: inherit; color: inherit; margin-bottom: 2px; padding: 5px 9px; border: 1px solid #ccc; border-radius: 3px }
.doc-config { margin-bottom: 2em; }
</style>
<div class="doc-config doc-grid">
<input type="text" aria-hidden="true" tabindex="-1" id="docs-copy" class="doc-hidden">
<input type="text" class="doc-input" name="search" placeholder="Type to search" autocomplete="off" aria-label="Filter icons">
</div>
<div class="docs-icons doc-grid" style="padding:0 7vw;margin:0 -7vw;transition:.2s"></div>
<script src="core-icons.min.js"></script>
<script src="readme.js"></script>
demo-->

## Accessibility

Modern versions of assistive technologies will announce SVG content, but there is still a lot of differences between browsers. To avoid confusion, use the following conventions:
Expand Down
92 changes: 52 additions & 40 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,13 @@
"static-publish": "npm run build && static-publish --directory=lib --account=nrk-core --latest --major"
},
"devDependencies": {
"@nrk/svg-to-js": "2.1.1",
"@nrk/svg-to-js": "^2.1.2",
"archiver": "^3.1.1",
"esm": "^3.2.25",
"http-server": "0.12.0",
"parse-svg": "0.0.0",
"http-server": "^0.12.0",
"parse-svg": "^0.0.0",
"pdfkit": "^0.10.0",
"standard": "^14.3.0",
"standard": "^14.3.1",
"svgson": "^4.0.0"
},
"repository": {
Expand Down

0 comments on commit 9b8cbc1

Please sign in to comment.