Declare the icons "as const" instead of strings (#303)

* Declare the icons as consts instead of strings, making them all unique. * chore: Update @nrk/svg-to-js to v3.1.0 * fix: Use dtsLiteral from svg-to-js instead of custom parser --------- Co-authored-by: Skjalg Teig <[email protected]>
nrkno · Aug 21, 2024 · 4a32acd · 4a32acd
1 parent 074b81b
commit 4a32acd
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 11 deletions.
diff --git a/bin/build.js b/bin/build.js
@@ -139,7 +139,7 @@ function buildIcons (groupName) {
   // Generate js and mjs with types for icons and logos
   fse.writeFileSync(path.join(npmPath, `${bundleName}.js`), icons.cjs)
   fse.writeFileSync(path.join(npmPath, `${bundleName}.mjs`), icons.esm)
-  fse.writeFileSync(path.join(npmPath, `${bundleName}.d.ts`), icons.dts)
+  fse.writeFileSync(path.join(npmPath, `${bundleName}.d.ts`), icons.dtsLiteral)
 
   // Generate jsx and mjsx with types for icons and logos
   fse.writeFileSync(path.join(npmJsxFolder, npmPath, `${bundleName}.js`), icons.cjsx)
@@ -170,7 +170,7 @@ function buildIcons (groupName) {
         // Generate js and mjs with types for icons and logos
         fse.writeFileSync(path.join(npmLargePath, `${largeBundleName}.js`), largeIcons.cjs)
         fse.writeFileSync(path.join(npmLargePath, `${largeBundleName}.mjs`), largeIcons.esm)
-        fse.writeFileSync(path.join(npmLargePath, `${largeBundleName}.d.ts`), largeIcons.dts)
+        fse.writeFileSync(path.join(npmLargePath, `${largeBundleName}.d.ts`), largeIcons.dtsLiteral)
 
         // Generate jsx and mjsx with types for icons and logos
         fse.writeFileSync(path.join(npmJsxFolder, npmLargePath, `${largeBundleName}.js`), largeIcons.cjsx)

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -87,7 +87,7 @@
   },
   "devDependencies": {
     "@arethetypeswrong/cli": "0.15.4",
-    "@nrk/svg-to-js": "3.0.1",
+    "@nrk/svg-to-js": "3.1.0",
     "@types/fs-extra": "11.0.4",
     "archiver": "6.0.1",
     "chokidar-cli": "3.0.0",