DEP: Loosen dependency requirements #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay, this now relaxes a lot of other dependencies and uses Other than that, I think we're good to go here. |
arokem
reviewed
Feb 21, 2021
| @@ -173,7 +173,7 @@ def predict(self, X): | |||
| """ | |||
| scores = self.decision_function(X) | |||
| if len(scores.shape) == 1: | |||
| indices = (scores > 0).astype(np.int) | |||
| indices = (scores > 0).astype(np.int32) | |||
There was a problem hiding this comment.
It's a numpy thing. I was getting warnings about np.int and np.float being deprecated in favor of either the build in Python int and float or the specific np.int32 and np.float64.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by this pyAFQ PR, this PR loosens groupyr's dependency requirements.