fix: add missing fields, fix up array type, add comments #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styfle
reviewed
Jul 1, 2024
Co-authored-by: Steven <[email protected]>
|
Ugh. Fixture tests failing... looking into it. |
|
CI tests were failing because Quick fix was to |
Merged
reggi
reviewed
Jul 19, 2024
|
Thanks a bunch for the changes! I found one issue with overrides! |
'Turns out VSCode and `tsc` aren't able to "find" the types if the package.json#exports field is defined. 'Something to do with the NodeNext loading logic? I'm not sure what exactly the issue is, but removing this field from package.json fixes the problem.
reggi
approved these changes
Jul 24, 2024
reggi
pushed a commit
that referenced
this pull request
Aug 13, 2024
🤖 I have created a release *beep* *boop* --- ## [2.0.0](v1.0.2...v2.0.0) (2024-08-07) ###⚠️ BREAKING CHANGES * update types (#29) * refactor to use @npmcli/template-oss (#31) ### Features * [`123bb67`](123bb67) [#29](#29) update types (#29) (@broofa, @jablko, @lukekarrys) * [`f09f754`](f09f754) [#31](#31) refactor to use @npmcli/template-oss (#31) (@lukekarrys) ### Bug Fixes * [`6ffee7f`](6ffee7f) [#60](#60) add missing fields, fix up array type, add comments (#60) (@broofa, @styfle) * [`4548f2c`](4548f2c) [#39](#39) linting cleanup (#39) (@lukekarrys) ### Documentation * [`5511d4b`](5511d4b) [#40](#40) fix README typo, improve PackageJSON description (#40) (@broofa, @styfle) * [`1a08144`](1a08144) [#37](#37) fix typo in readme (#37) (@lukekarrys) ### Chores * [`d323311`](d323311) [#70](#70) bump @types/node from 20.12.10 to 22.1.0 (#70) (@dependabot[bot]) * [`4761562`](4761562) [#71](#71) bump @typescript-eslint/parser from 7.18.0 to 8.0.1 (#71) (@dependabot[bot]) * [`3687a18`](3687a18) [#38](#38) simplify template-oss config (#38) (@lukekarrys) * [`1a1fd85`](1a1fd85) [#36](#36) remove build script and update snapshots and tsconfig (#36) (@lukekarrys) * [`3172a32`](3172a32) update template-oss files for main branch (@lukekarrys) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making the following changes:
fundinglicenses(deprecated)overridespeerDependenciesMetaworkspacescontributorsReferences
PackageJsontype missing numerous npm-documented fields #25