of_json: pass type of action to the underlying ofp_action_-classes #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eeded by ofp_action_dl_addr, ofp_action_nw_addr and ofp_action_tp_port)
|
Does this work in all cases? I'd think it'd cause an exception for the other action types, which is why I mentioned catching it and trying again. |
|
Worked in almost all cases, now in all cases. Thanks for pointing it out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is needed by ofp_action_dl_addr, ofp_action_nw_addr and ofp_action_tp_port.
The pull request "some action-functions in libopenflow_01 need the type set #158" will be closed.