Fix possible null error in SLA modules (librenms#13046)

nox-x · Jul 16, 2021 · ca621fb · ca621fb
1 parent fb6da83
commit ca621fb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/LibreNMS/OS/Shared/Cisco.php b/LibreNMS/OS/Shared/Cisco.php
@@ -321,7 +321,7 @@ public function discoverSlas()
                 'sla_nr' => $index,
                 'owner' => $sla_config['rttMonCtrlAdminOwner'] ?? '',
                 'tag' => $this->getSlaTag($sla_config),
-                'rtt_type' => $sla_config['rttMonCtrlAdminRttType'],
+                'rtt_type' => $sla_config['rttMonCtrlAdminRttType'] ?? '',
                 'rtt' => $sla_config['rttMonLatestRttOperCompletionTime'] ?? null,
                 'status' => ($sla_config['rttMonCtrlAdminStatus'] == 'active') ? 1 : 0,
                 'opstatus' => ($sla_config['rttMonLatestRttOperSense'] == 'ok') ? 0 : 2,

diff --git a/LibreNMS/OS/Vrp.php b/LibreNMS/OS/Vrp.php
@@ -501,7 +501,7 @@ public function discoverSlas()
                 'sla_nr' => hexdec(hash('crc32', $owner . $test)), // indexed by owner+test, convert to int
                 'owner' => $owner,
                 'tag' => $test,
-                'rtt_type' => $sla_config['nqaAdminCtrlType'],
+                'rtt_type' => $sla_config['nqaAdminCtrlType'] ?? '',
                 'rtt' => isset($sla_config['pingResultsAverageRtt']) ? $sla_config['pingResultsAverageRtt'] / 1000 : null,
                 'status' => ($sla_config['pingCtlAdminStatus'] == 'enabled') ? 1 : 0,
                 'opstatus' => ($sla_config['pingCtlRowStatus'] == 'active') ? 0 : 2,