Initial Engine Audio Additions #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SoapyEnigma
commented
Sep 12, 2024
SoapyEnigma
commented
- Added miniaudio -- Used for audio playing (game) and conversion (asset converter).
- Added stb_vorbis -- Used for vorbis/ogg conversion (asset converter).
- Added AudioManager -- Used to handle audio and functionality (game).
- Updated premake lua files, dependencies and modules, to include new audio related files.
- Added miniaudio -- Used for audio playing (game) and conversion (asset converter). - Added stb_vorbis -- Used for vorbis/ogg conversion (asset converter). - Added AudioManager -- Used to handle audio and functionality (game). - Updated premake lua files, dependencies and modules, to include new audio related files.
Updated for file selection for asset browser in Game
- Initial/preemptive update to handle future multiple sound source -- Update to handle asset browser and command console audio separately.
Pursche
requested changes
Sep 28, 2024
| if (endAllOtherAudio && ma_sound_is_playing(_assetBrowserSound)) | ||
| ma_sound_uninit(_assetBrowserSound); | ||
|
|
||
| _assetBrowserSound = new ma_sound(); |
There was a problem hiding this comment.
We don't perticularly like having implementation details like "asset browser sound" in the AudioManager. It would be better if you could create channels in the AudoManager, and then you can play sounds in a specific channel, stop everything playing in a specific channel etc. Then for example the AudioDebugWindow or whatever you would call the editor window would create a channel for itself and use that channel to play/stop sounds.
There was a problem hiding this comment.
When I say Channel here, I mean MA's Sound Groups, like "Music", "Ambience", "Sound effects" etc. Not for example left and right channel on headphones. :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.