Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transaction hashes to relevant governance events #856

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

pedropregueiro
Copy link
Contributor

Useful for nouns clients to link to the specific transaction on-chain.

@eladmallel
Copy link
Collaborator

good one @pedropregueiro

@davidbrai
Copy link
Collaborator

@pedropregueiro I've pushed this branch here: https://api.goldsky.com/api/public/project_cldf2o9pqagp43svvbk5u3kmo/subgraphs/nouns/0.2.7/gn

take a look please. if it looks good to you I can promote it to be the "prod" subgraph

@pedropregueiro
Copy link
Contributor Author

@pedropregueiro I've pushed this branch here: https://api.goldsky.com/api/public/project_cldf2o9pqagp43svvbk5u3kmo/subgraphs/nouns/0.2.7/gn

take a look please. if it looks good to you I can promote it to be the "prod" subgraph

thanks @davidbrai! I did test it with camp's graph endpoints, but if you deploy the latest version - d8fbd8c - I can point camp to that graph and test again.

@davidbrai
Copy link
Collaborator

@pedropregueiro
Copy link
Contributor Author

yep, seems to all be working as expected!

@davidbrai davidbrai merged commit 8a602f6 into nounsDAO:master Aug 2, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants