Client Incentives + Noracle #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in case the DAO wants to start the spend or burn sooner
in case the settlements were warmed up, the timestamp in change to 1 and the previous check would fail
to reduce diff and it's easier to debug in many cases
it's not bit-packed when placed after the auction struct and for now we prefer to not force it into the auction struct esp. since bigger gas savings are coming from descriptor storage read optimizations
because we hit the contract size limit, this commit has a POC for reducing it. all the admin functions are replaced with a fallback function that delegate calls the admin lib.
getPrices(n)
- returns exactly `n` latest auction prices
- skips auctions with no bids
- skips nounder noun ids
- reverts if auction should have data but doesn't
- reverts if not enough items in history (not need to trim)
-> either returns array of n-length or reverts
getSettlements(n, skipEmptyValues)
- returns up to `n` latest settlement (in case we reach id 0)
- includes auction with no bids (blockTimestamp will be > 1)
- skips nounder noun ids if skipEmptyValues = true, otherwise return raw
- skip unset data if skipEmptyValues = true, otherwise return raw
getSettlements(x, y, skipEmptyValues)
- returns settlements for ids [x,y)
- includes auction with no bids (blockTimestamp will be > 1)
- skips nounder noun ids if skipEmptyValues = true, otherwise return raw
- skip unset data if skipEmptyValues = true, otherwise return raw
…nd-reduce-contract-size
…incentives-noracle
cache storage vars
moved the voting ended check into `proposalDataForRewards`. otherwise, a proposal that hasn't yet finished voting may get filtered out due to not meeting the quorum requirements and the `nextProposalIdToReward` could be set to a proposalId after it. This would cause that proposal to not get rewards.
…ix-1 Fix for rewards contract following audit
…an-set-descriptor allow admin to set rewards descriptor
werme
reviewed
Apr 29, 2024
| return ds.proposalsV3(proposalId); | ||
| } | ||
|
|
||
| /** | ||
| * @notice Get a range of proposals, in the format of a samller struct tailored to client incentives rewards. |
separate params setting functions added a function to enable each one individually which also resets the next id to reward
…posal splitting auction & proposal rewards
solimander
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.