Subgraph: fix issue with delegation changes on transfer events #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @solimander, got some time to take a look at this in the coming days? the issue is currently affecting most noun frontend clients including nouns.wtf and nouns.camp thanks! 🙌 |
solimander
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #819
The
handleTransferevent wrongly updates thedelegatefield of existing token holder accounts when transferring all nouns.The
delegatevalue should only change either a) when explicitly changed via contract; or b) when a new holder buys their first noun, in which case it should self-delegate the votes. Otherwise, if thedelegatehas been set to another account, it should remain until explicitly changed.Created a new test file for testing these erc-721 actions.