Trix compatibility & allow developpers to setup more replacements on create

[gael-ian]

Should fix #65

[jhirn]

Hey @gael-ian.

I was trying to load this branch on my project with import maps but not quite sure how to load the Javascript . This is my first experience with import maps but it's defaults resolving jsdeliver. should I hard code the full path to the gem's install directory (specifically /npm)? I tried to unpin and build from scratch to import via manifest.js but hope you could save me some wrangling.

Any tips?

[jhirn]

This doesn't seem limited to <trix-editor> elements.

I know input is a Trix specific html attribute but I'm curious if this could introduce issues with other RTEs or JS plugins which rely on that attribute for another purpose. You'd need a method to opt-out in those cases if this is going to automatically replace input attribute on any html element.

[gael-ian]

You're right, even if chances are small it will match with an input attribute on another tag and find a match with both association name and delimiters in its value and ends doing a wrong replacement.

I changed the Replacement class to support an optional tag argument in its constructor to restrain matches. It should be fine now.

[gael-ian]

@jhirn

Any tips?

Sorry, I don't use importmap myself (I'm not convinced by the idea of having two different tools and pipelines to bundle things that can be as intertwined as JavaScript and CSS) so I can't help you :/

[jhirn]

@jhirn

Any tips?

Sorry, I don't use importmap myself (I'm not convinced by the idea of having two different tools and pipelines to bundle things that can be as intertwined as JavaScript and CSS) so I can't help you :/

I agree with you 100%. First time trying out import maps and it's been kind of a headache.

I can't pull this into my app to test the fix but reading through the code it feels like it would do the trick (and more). Thanks for the feature add!