Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Format() to timestamp #30

Merged
merged 4 commits into from
Jul 15, 2024
Merged

Conversation

Two-Hearts
Copy link
Contributor

Resolves #29

Signed-off-by: Patrick Zheng <[email protected]>
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.24%. Comparing base (80d3869) to head (bb5c501).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   95.21%   95.24%   +0.02%     
==========================================
  Files          19       19              
  Lines         732      736       +4     
==========================================
+ Hits          697      701       +4     
  Misses         18       18              
  Partials       17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Patrick Zheng <[email protected]>
timestamp.go Outdated Show resolved Hide resolved
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts Two-Hearts changed the title update: added String() to timestamp feat: added Format() to timestamp Jul 15, 2024
@Two-Hearts Two-Hearts requested a review from shizhMSFT July 15, 2024 08:23
timestamp.go Outdated Show resolved Hide resolved
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts Two-Hearts changed the title feat: added Format() to timestamp feat: add Format() to timestamp Jul 15, 2024
Copy link

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts merged commit df25ef8 into notaryproject:main Jul 15, 2024
9 checks passed
@Two-Hearts Two-Hearts deleted the enhance branch July 15, 2024 23:56
@Two-Hearts Two-Hearts mentioned this pull request Aug 6, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a String() or Format() method for Timestamp struct
4 participants