doc: add back mistakenly removed sentence #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yi Zha <[email protected]>
yizha1
requested review from
gokarnm,
NiazFK,
priteshbandi,
shizhMSFT,
toddysm and
vaninrao10
as code owners
shizhMSFT
reviewed
Jul 30, 2024
There was a problem hiding this comment.
These attributes are typically signed by a third party (e.g. CA, TSA).
This sentence is misleading that readers may think unsigned attributes are counter signatures. However, they are not.
Again, unsigned attributes can be added or stripped without signers' notice even if they are signed by a 3rd party.
|
@shizhMSFT do you have any suggestions? In most cases (typically), the unsigned attributes contain attributes that are signed by CA or TSA. |
Signed-off-by: Yi Zha <[email protected]>
toddysm
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #274
Signed-off-by: Yi Zha [email protected]