fix: add warning message for non-revokable certificate #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Junjie Gao <[email protected]>
JeyJeyGao
requested review from
gokarnm,
NiazFK,
priteshbandi,
rgnote,
shizhMSFT,
toddysm,
Two-Hearts,
vaninrao10 and
yizha1
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #479 +/- ##
==========================================
+ Coverage 80.34% 80.36% +0.01%
==========================================
Files 34 34
Lines 3323 3326 +3
==========================================
+ Hits 2670 2673 +3
Misses 508 508
Partials 145 145 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Junjie Gao <[email protected]>
Two-Hearts
reviewed
Nov 21, 2024
|
#480 |
Two-Hearts
pushed a commit
to Two-Hearts/notation-go
that referenced
this pull request
Dec 9, 2024
…#479) Fix: - added warning message for non-revokable certificate --------- Signed-off-by: Junjie Gao <[email protected]> Signed-off-by: Patrick Zheng <[email protected]>
Two-Hearts
pushed a commit
to Two-Hearts/notation-go
that referenced
this pull request
Dec 9, 2024
…#479) Fix: - added warning message for non-revokable certificate --------- Signed-off-by: Junjie Gao <[email protected]> Signed-off-by: Patrick Zheng <[email protected]>
Two-Hearts
pushed a commit
to Two-Hearts/notation-go
that referenced
this pull request
Dec 9, 2024
…#479) Fix: - added warning message for non-revokable certificate --------- Signed-off-by: Junjie Gao <[email protected]> Signed-off-by: Patrick Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: