Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an indicator when trailer is loading #282

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chet-manley
Copy link

This prevents the trailer_unavailable image from appearing when the
Add Movie details modal first opens and the trailer has not yet been
loaded. Instead, the app's "busy/loading" indicator is shown until
the AJAX call completes. On success, embed the trailer. On failure,
display the trailer_unavailable image.

Chet Manley and others added 2 commits November 13, 2018 05:06
This prevents the `trailer_unavailable` image from showing when the
Add Movie `details` modal first opens and the trailer has not yet been
returned. Instead, the app's "busy/loading" indicator is shown until
the AJAX call completes. On success, embed the trailer. On failure,
display the `trailer_unavailable` image.
Accidentally added "loading" class to containing div.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant