Fix postprocessor getting disabled after scan #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you expand on what you mean by "without sane parameters"? It looks to me like you're just undoing the 60-second expansion a few lines before your change... |
|
I think originally it creates a scheduling conflict. The code goes back and
forth between my pull request and the original commit. Not sure why it was
decided so.
…On Mon., Jul. 8, 2019, 6:42 a.m. Barbeque Sauce, ***@***.***> wrote:
Can you expand on what you mean by "without sane parameters"? It looks to
me like you're just undoing the 60-second expansion a few lines before your
change...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#277?email_source=notifications&email_token=ABMJBTIHRXJ2JCNDUEPAGYLP6MY4XA5CNFSM4GBLJNHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZM6XUI#issuecomment-509209553>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABMJBTK7MH5UKE6SDRKKDS3P6MY4XANCNFSM4GBLJNHA>
.
|
|
Additionally, I you think about the minute parameter, it is not reasonable
to pass 5*60 + now minute as a minute, that would mean start run at hour
now and minute 300 the least, which is impossible.
…On Mon., Jul. 8, 2019, 6:42 a.m. Barbeque Sauce, ***@***.***> wrote:
Can you expand on what you mean by "without sane parameters"? It looks to
me like you're just undoing the 60-second expansion a few lines before your
change...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#277?email_source=notifications&email_token=ABMJBTIHRXJ2JCNDUEPAGYLP6MY4XA5CNFSM4GBLJNHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZM6XUI#issuecomment-509209553>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABMJBTK7MH5UKE6SDRKKDS3P6MY4XANCNFSM4GBLJNHA>
.
|
|
I see your point... thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Postprocessor scanner gets disabled after the first scan, I believe this is because the scheduler plugin creates the task without sane parameters. It asks for it to run with an interval of 5 minutes starting (5*60) from initial execution.