Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respawn.cs API improvements #229

Open
wants to merge 2 commits into
base: 13.1
Choose a base branch
from

Conversation

NotIntense
Copy link

No description provided.

NwPluginAPI/Core/Respawn.cs Outdated Show resolved Hide resolved
NwPluginAPI/Core/Respawn.cs Outdated Show resolved Hide resolved
@Lufou
Copy link

Lufou commented Oct 1, 2023

Furthermore, why adding
Respawn.CurrentRespawnSequence(); when you can just do RespawnManager.CurrentSequence();
Respawn.ResetTickets(); when you can just do RespawnTokensManager.ResetTokens();
Respawn.ForceTeamLead(SpawnableTeamType teamType, float tokens); when you can just do RespawnTokensManager.ForceTeamDominance(teamType, tokens);
? :/

@NotIntense
Copy link
Author

NotIntense commented Oct 1, 2023

Furthermore, why adding Respawn.CurrentRespawnSequence(); when you can just do RespawnManager.CurrentSequence(); Respawn.ResetTickets(); when you can just do RespawnTokensManager.ResetTokens(); Respawn.ForceTeamLead(SpawnableTeamType teamType, float tokens); when you can just do RespawnTokensManager.ForceTeamDominance(teamType, tokens); ? :/

because it allows non-experienced C# devs and people who dont know where to find those methods into one, easy to access place

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants