New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DBC parser improvements #13

Open

ianrrees wants to merge 2 commits into normaldotcom:master from ianrrees:dbcparser

+39 −15

ianrrees commented Jun 28, 2023

This has two fixes, to enable canable to work with the Nissan Leaf DBC files published here.

Tokens weren't allowed to start with 'J' - I have not checked the DBC spec but assume that was a simple typo.
String type tokens can now include internal double-quote characters, escaped like \".


          DBC IDs can start with 'J'

33fb7e5

ianrrees force-pushed the dbcparser branch 3 times, most recently from a814e7d to 421366c Compare

June 28, 2023 22:35

Author

ianrrees commented Jun 28, 2023

Sorry about the force-pushes - I was tinkering with this late last night, then woke up with thoughts of how to improve it further :).


          Allow escaped double quotes in DBC strings

5c9e311

ianrrees force-pushed the dbcparser branch from 421366c to 5c9e311 Compare

June 29, 2023 02:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet