Bug-fix for fetching region from AWS cluster obj in GetAWSRegion() #1483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achouhan09
requested review from
dannyzaken,
liranmauda,
tangledbytes and
naveenpaul1
achouhan09
force-pushed
the
region-fix
branch
from
b3b1b9c to
f7dcb3d
Compare
achouhan09
force-pushed
the
region-fix
branch
from
f7dcb3d to
c39f14b
Compare
liranmauda
reviewed
Dec 4, 2024
dannyzaken
reviewed
Dec 5, 2024
achouhan09
force-pushed
the
region-fix
branch
from
c39f14b to
e1e4c37
Compare
achouhan09
force-pushed
the
region-fix
branch
3 times, most recently
from
25cd161 to
e4a11ef
Compare
dannyzaken
reviewed
Dec 11, 2024
dannyzaken
approved these changes
Dec 11, 2024
Signed-off-by: Aayush Chouhan <[email protected]>
achouhan09
force-pushed
the
region-fix
branch
from
e4a11ef to
00c3d88
Compare
vh05
pushed a commit
to vh05/noobaa-operator
that referenced
this pull request
Dec 11, 2024
Bug-fix for fetching region from AWS cluster obj in GetAWSRegion() Signed-off-by: Vinayak Hariharmath <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Root Cause: The problem arises when the AWS cluster region cannot be determined from node names, especially in cases where the node naming convention does not include the region or when the DHCP option modifies DNS settings, causing standard parsing methods to fail.
Solution: To resolve this, the solution first attempts to fetch the region directly from the cluster configuration, which is the most reliable source. If this fails, it falls back to parsing the region from the node name.
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: