Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSFS | Replace ChunkFS with FileWriter #8577

Merged
merged 1 commit into from
Dec 9, 2024
Merged

NSFS | Replace ChunkFS with FileWriter #8577

merged 1 commit into from
Dec 9, 2024

Conversation

romayalon
Copy link
Contributor

Explain the changes

  1. Added @guymguym's changes to Replace ChunkFS with FileWriter.
  2. Applied the existing copy changes, removed the readable resume().
  3. Replaced ChunkFS usage in other files to FileWriter usage.

Issues: Fixed #xxx / Gap #xxx

  1. Fixed NSFS | ChunkFS | Inconsistent data corruption when copying using Spark #8574

Testing Instructions:

  1. See detailed instructions in the issue.
  2. test_namespace_fs
  3. test_file_writer
  4. node /noobaa-core/src/tools/file_writer_hashing.js --hash
  5. node /noobaa-core/src/tools/file_writer_hashing.js --file
  • Doc added/updated
  • Tests added

@romayalon romayalon force-pushed the romy-file-writer branch 2 times, most recently from 1168f81 to 94c3ef9 Compare December 4, 2024 14:08
guymguym
guymguym reviewed Dec 4, 2024
View reviewed changes
src/sdk/namespace_fs.js Outdated Show resolved Hide resolved
src/sdk/namespace_fs.js Outdated Show resolved Hide resolved
src/util/file_writer.js Outdated Show resolved Hide resolved
@romayalon romayalon requested a review from guymguym December 5, 2024 08:05
@romayalon romayalon requested a review from guymguym December 8, 2024 11:09
guymguym
guymguym approved these changes Dec 9, 2024
View reviewed changes
config.js Outdated Show resolved Hide resolved
@romayalon romayalon merged commit cf0daca into noobaa:master Dec 9, 2024
10 checks passed
This was referenced Dec 10, 2024
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guymguym guymguym guymguym approved these changes

@nadavMiz nadavMiz Awaiting requested review from nadavMiz

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NSFS | ChunkFS | Inconsistent data corruption when copying using Spark
2 participants
@romayalon @guymguym