NC | Online Upgrade | Health CLI update config directory and upgrade checks #8532
+186
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…checks Signed-off-by: Romy <[email protected]>
romayalon
force-pushed
the
romy-online-upgrade-health
branch
from
89f3503
to
45af106
Compare
naveenpaul1
reviewed
Nov 18, 2024
| phase: config_dir_data.phase, | ||
| config_dir_version: config_dir_data.config_dir_version, | ||
| upgrade_package_version: config_dir_data.upgrade_package_version, | ||
| in_progress_upgrade: config_dir_data.in_progress_upgrade |
There was a problem hiding this comment.
Do we need to add error type for config and upgrad status?
| @@ -136,6 +138,8 @@ class NSFSHealth { | |||
| endpoint_state, | |||
| error_type: health_errors_tyes.TEMPORARY, | |||
| }, | |||
| config_directory_status: this._get_config_dir_status(system_data), | |||
| upgrade_status: this._get_upgrade_status(system_data), | |||
There was a problem hiding this comment.
update health doc for newly added properties.
shirady
reviewed
Dec 1, 2024
|
|
||
| /** | ||
| * get_upgrade_status returns the status of an ongoing upgrade, if valid it returns an object with upgrade details | ||
| * if upgrade is not ongoing but config dir is locked in one of the hosts, the error details will return |
There was a problem hiding this comment.
Where do we return the "an object with upgrade details" I don't see it?
| @@ -45,6 +56,10 @@ mocha.describe('nsfs nc health', function() { | |||
| }); | |||
|
|
|||
| mocha.describe('nsfs nc health cli validations', function() { | |||
| mocha.afterEach(() => { | |||
There was a problem hiding this comment.
It was at the beginning of each it, right? why not use beforeEach?
| }); | ||
|
|
||
| mocha.it('Health all condition is success', async function() { | ||
| const get_service_state = sinon.stub(Health, "get_service_state"); | ||
| mocha.it('Health all condition is success1', async function() { |
There was a problem hiding this comment.
Was this "1" intentional?
Suggested change
| mocha.it('Health all condition is success1', async function() { | |
| mocha.it('Health all condition is success', async function() { |
| get_endpoint_response.onFirstCall().returns(Promise.resolve({response: {response_code: 'RUNNING', total_fork_count: 0}})); | ||
| const health_status = await Health.nc_nsfs_health(); | ||
| assert.strictEqual(health_status.checks.accounts_status.valid_accounts.length, 1); | ||
| assert.strictEqual(health_status.checks.accounts_status.invalid_accounts.length, 1); | ||
| await exec_manage_cli(TYPES.ACCOUNT, ACTIONS.DELETE, { config_root, name: account_invalid.name }); | ||
| }); | ||
|
|
||
| mocha.it('Health all condition - invalid config directory upgrade', async function() { |
There was a problem hiding this comment.
Would you add a comment - what makes it invalid?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Upgrade, it's showing in the logs of the endpoint, CLI etc.Issues: Fixed #xxx / Gap #xxx
Testing Instructions:
sudo node ./node_modules/mocha/bin/mocha src/test/unit_tests/test_nc_health.js