PR1 - To install and upgrade noobaa version for running the tests #8517
Conversation
achouhan09
force-pushed
the
upgrade-tests
branch
8 times, most recently
from
1032b01
to
15a23fc
Compare
achouhan09
force-pushed
the
upgrade-tests
branch
from
15a23fc
to
3f4cf92
Compare
achouhan09
changed the title
achouhan09
force-pushed
the
upgrade-tests
branch
from
3f4cf92
to
8515ca8
Compare
achouhan09
force-pushed
the
upgrade-tests
branch
from
8515ca8
to
e496520
Compare
| @@ -0,0 +1,94 @@ | |||
| name: Upgrade Tests | |||
| on: [push, pull_request, workflow_dispatch] | |||
There was a problem hiding this comment.
Are you sure you want to run this workflow on every PR?
From what you ran so far was it stable? (no false failures)
There was a problem hiding this comment.
Yes I think, here we want to run the tests after upgrading to the latest code pushed.
.github/workflows/upgrade-tests.yaml
Outdated
| ./.travis/number_of_pods_in_system.sh --pods 5 | ||
| kubectl wait --for=condition=available backingstore/noobaa-default-backing-store --timeout=5m | ||
|
|
||
| - name: Run Upgrade Tests (PR code) |
There was a problem hiding this comment.
You can remove this comment after the code review
| - name: Run Upgrade Tests (PR code) | |
| - name: Run Upgrade Tests |
| - name: Upgrade noobaa to latest | ||
| run: | | ||
| cd ./noobaa-operator | ||
| ./build/_output/bin/noobaa-operator upgrade --noobaa-image='noobaa-core:upgrade-tests' |
There was a problem hiding this comment.
From the comments I can see that:
"The command should be used in conjunction with the global flags --noobaa-image and --operator-image to upgrade the system and its components to the desired versions."
reference, I noticed only one flag (--noobaa-image).
There was a problem hiding this comment.
If its required here to provide both the flags then I will add --operator-image also. Thanks
There was a problem hiding this comment.
What do you mean by "latest"? can you give an example?
The current version is 5.18, we released 5.17, what do we want the script to test?
Could you echo a line that prints the upgrade that we test here somewhere?
There was a problem hiding this comment.
The idea here is that we are first installing operator with master code and then we are upgrading the images with the latest code pushed.
Makefile
Outdated
| test-upgrade: tester | ||
| @echo "\033[1;34mRunning Upgrade Tests - after upgrading from master to latest\033[0m" | ||
| chmod +x ./src/test/system_tests/run_upgrade_tests.sh | ||
| ./src/test/system_tests/run_upgrade_tests.sh || exit 1 |
There was a problem hiding this comment.
It is just for phase1 testing purpose. I will remove it. Thanks
.github/workflows/upgrade-tests.yaml
Outdated
| make noobaa NOOBAA_TAG=noobaa-core:upgrade-tests | ||
|
|
||
| - name: Checkout noobaa-operator | ||
| uses: actions/checkout@v3 |
There was a problem hiding this comment.
Why actions/checkout@v3?
The others are actions/checkout@v4.
I mean in the jobs that we download both of them:
Download action repository 'actions/checkout@v4' (SHA:11bd71901bbe5b1630ceea73d27597364c9af683)
Download action repository 'actions/checkout@v3' (SHA:f43a0e5ff2bd294095638e18286ca9a3d1956744)
There was a problem hiding this comment.
Its a typo, I will update it to v4 for all. Thanks
.github/workflows/upgrade-tests.yaml
Outdated
| cd ./noobaa-operator | ||
| ./build/_output/bin/noobaa-operator upgrade --noobaa-image='noobaa-core:upgrade-tests' | ||
|
|
||
| - name: Wait for phase Ready in the backingstore pod |
There was a problem hiding this comment.
Why do we need to wait again for the backingstore pod?
Could you add a comment about it
There was a problem hiding this comment.
I think you are right it is not required after upgrading. I will verify it once and update accordingly. Thanks
Signed-off-by: Aayush Chouhan <[email protected]>
Signed-off-by: Aayush Chouhan <[email protected]>
achouhan09
force-pushed
the
upgrade-tests
branch
from
e496520
to
fc33e4d
Compare
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: