Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSFS | Improve list objects performance on top of NS FS (PR 2/3) #8422

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

NSFS | Improve list objects performance on top of NS FS (PR 2/3) #8422

wants to merge 1 commit into from

Conversation

naveenpaul1
Copy link
Contributor

Explain the changes

  1. This is Second PR for listing unordered objects.
  2. This PR contains changes in list_object(), TellDir value is passed to next list object result and same value is used to seekdir dir location.
  3. Global flag is added in config for controlling bucket list flow.
    NB : New parameter next_pos added to API list_objects to pass the seek position. I tried to pass this along with next_marker as a object but Ceph test failed when comparing next_marker.

Issues: Fixed #xxx / Gap #xxx

  1. Improve list objects performance on top of NS FS #6615

Testing Instructions:

  1. Run ListObject API after enabling global property ALLOW_NSFS_UNSORTED_OBJECTS_LIST, Result should retun with unsorted list.

closed PR : #7983

  • Doc added/updated
  • Tests added

@naveenpaul1 naveenpaul1 closed this Oct 9, 2024
@naveenpaul1 naveenpaul1 reopened this Oct 9, 2024
@naveenpaul1 naveenpaul1 marked this pull request as draft October 9, 2024 04:35
@naveenpaul1 naveenpaul1 force-pushed the new_nsfs_list_objects_2 branch 4 times, most recently from 51cec93 to 77fc48b Compare October 16, 2024 12:47
@naveenpaul1 naveenpaul1 marked this pull request as ready for review October 17, 2024 10:10
@naveenpaul1 naveenpaul1 force-pushed the new_nsfs_list_objects_2 branch 3 times, most recently from 3fa1b5a to b2f5de0 Compare December 3, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guymguym guymguym Awaiting requested review from guymguym

@romayalon romayalon Awaiting requested review from romayalon

@tangledbytes tangledbytes Awaiting requested review from tangledbytes

@dannyzaken dannyzaken Awaiting requested review from dannyzaken

@jackyalbo jackyalbo Awaiting requested review from jackyalbo

@liranmauda liranmauda Awaiting requested review from liranmauda

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@naveenpaul1