Merge pull request #8562 from shirady/backport-into-5_17

[Backport into 5.17] Removing `unique` and the unused `NAN_SET_BUF_DETACH`
noobaa · Nov 28, 2024 · ee50557 · ee50557
2 parents 07bb564 + 3000867
commit ee50557
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 12 deletions.
diff --git a/src/native/util/buf.h b/src/native/util/buf.h
@@ -167,12 +167,6 @@ class Buf
         return _alloc->detach();
     }
 
-    inline bool
-    unique_alloc()
-    {
-        return _alloc.unique();
-    }
-
     inline bool
     same(const Buf& buf) const
     {

diff --git a/src/native/util/nan.h b/src/native/util/nan.h
@@ -71,12 +71,6 @@ NanKey(std::string s)
 #define NAN_SET_NUM(obj, key, val) (NAN_SET(obj, key, Nan::New<v8::Number>(val)))
 #define NAN_SET_BUF_COPY(obj, key, buf) \
     (NAN_SET(obj, key, Nan::CopyBuffer(buf.cdata(), buf.length()).ToLocalChecked()))
-#define NAN_SET_BUF_DETACH(obj, key, buf)                                              \
-    do {                                                                               \
-        assert(buf.unique_alloc());                                                    \
-        NAN_SET(obj, key, Nan::NewBuffer(buf.cdata(), buf.length()).ToLocalChecked()); \
-        buf.detach_alloc();                                                            \
-    } while (0)
 
 #define NAN_ERR(msg) (Nan::To<v8::Object>(Nan::Error(msg)).ToLocalChecked())
 #define NAN_RETURN(val)                 \