Skip to content

Commit

Permalink
add more details in Could not log bucket operation err + add comment …
Browse files Browse the repository at this point in the history
…in the code

Signed-off-by: shirady <[email protected]>
  • Loading branch information
shirady committed Nov 19, 2024
1 parent df6479f commit ecb3129
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions src/endpoint/s3/s3_rest.js
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ async function s3_rest(req, res) {
try {
await s3_logging.send_bucket_op_logs(req, res); // logging again with error
} catch (err1) {
dbg.error("Could not log bucket operation:", err1);
dbg.error("Could not log bucket operation (after handle_error):", err1);
}
}
}
Expand Down Expand Up @@ -134,7 +134,7 @@ async function handle_request(req, res) {
try {
await s3_logging.send_bucket_op_logs(req); // logging intension - no result
} catch (err) {
dbg.error("Could not log bucket operation:", err);
dbg.error(`Could not log bucket operation (before operation ${req.op_name}):`, err);
}
}

Expand Down Expand Up @@ -165,7 +165,9 @@ async function handle_request(req, res) {
try {
await s3_logging.send_bucket_op_logs(req, res); // logging again with result
} catch (err) {
dbg.error("Could not log bucket operation:", err);
// GAP - (NC) since we don't have the bucket in bucket_namespace_cache we cannot get the bucket info
// after deleting the bucket
dbg.error(`Could not log bucket operation (after operation ${req.op_name}):`, err);
}

}
Expand Down

0 comments on commit ecb3129

Please sign in to comment.