Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: 添加 websockets 驱动器 proxy 连接警告 #2916

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Feature: 添加 websockets 驱动器 proxy 连接警告 #2916

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7420a62
✨ 在试图使用 websockets 驱动器通过 proxy 连接 ws 时抛出警告
shoucandanghehe Aug 21, 2024
0bc66ba
🔊 修改log用词
shoucandanghehe Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions nonebot/drivers/websockets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@
@override
@asynccontextmanager
async def websocket(self, setup: Request) -> AsyncGenerator["WebSocket", None]:
if setup.proxy is not None:
logger.warning("proxy is not supported by websockets driver")

Check warning on line 73 in nonebot/drivers/websockets.py

View check run for this annotation

Codecov / codecov/patch

nonebot/drivers/websockets.py#L73 

Added line #L73 was not covered by tests
connection = Connect(
str(setup.url),
extra_headers={**setup.headers, **setup.cookies.as_header(setup)},
Expand Down