PR init & fix to CoreContracts.ts applied #320
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anna-carroll
force-pushed
the
xiangan/patch
branch
2 times, most recently
from
356d3fa to
7a5fce1
Compare
|
we need to align on this #325 |
|
Closed for now as unnecessary in the present time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes to CoreContracts after a few lines were deleted that would currently prevent contract deployment.
Solution
Patched very straightforward, just need to revert the lines deleted in packages/deploy/src/core/CoreContracts.ts in this PR.
PR Checklist