-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: versioning for deploys #325
Comments
from @prestwich #312 (comment)
my response is.. hmmmm.. wdyt @Imti 😅 |
@prestwich logistically how would we check whether version of |
in other words, it's not a 1:1 mapping between |
I'm saying that CI already will fail to build if |
ah, yes. this is true. but.. how do we deploy from past versions? i guess just check out that version in a branch. |
yes |
I agree with @prestwich, basically following the convention for npm packages releases. Let me know if you need help setting this up. |
I think we have fixed this @anna-carroll ? |
Package
deploy
,contracts-core
,contracts-bridge
,contracts-router
Describe the feature you would like
need to design how we will handle versioning between
contracts-core
,contracts-bridge
,contracts-router
, anddeploy
packagesAs the contract code changes, the deploy script must sometimes also change (namely, if constructor / initialize / setup function interfaces change)
However, these packages are used in different places which each have different needs
Use cases:
We cannot just update the
package.json
of deploy package to choose which contracts to use, as we also need to use the right version of the deploy package itselfAdditional context
Relevant: all comments / discussion on this PR: #312
The text was updated successfully, but these errors were encountered: