Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bi-link): Invalidation of title reference #326

Merged
merged 6 commits into from
Nov 11, 2024

Conversation

LincZero
Copy link
Contributor

@LincZero LincZero commented Nov 8, 2024

如果遇到 [[#title]] 的情况,会导致编译报错

Copy link
Member

@LittleSound LittleSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. write the unit test code to ensure that the feature remains fixed in future versions.

Please check index.test.ts and you will see how to write unit tests, write your tests there.

@LincZero
Copy link
Contributor Author

LincZero commented Nov 8, 2024

I know, thanks.

However, I thought there was no syntax to support [[#title]], so I simply excluded it from the Reg. But now it seems that [[page#title]] is supported (which is why I failed the unit test), but not the [[#title]] case of ignoring page (which refers to a title of the article).

This also meant that I needed to use a different solution to solve the bug. I don't have enough time today. I may come back to repair it in a couple of days.

@nekomeowww
Copy link
Member

No worries, take your time.

Copy link

✅ Successfully deployed to Netlify

Platform Status URL
Ubuntu Success https://6731ae9345d9fcf32546556d--nolebase-integrations.netlify.app
Windows Success https://6731aea04020f1e7c09b1cef--nolebase-integrations.netlify.app

@nekomeowww
Copy link
Member

LGTM, thanks.

@nekomeowww nekomeowww merged commit 0145f42 into nolebase:main Nov 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants