Add accessibility labels to widgets that don't provide one themselves

nokyan · Mar 8, 2024 · 74904c1 · 74904c1
1 parent b8ef6d8
commit 74904c1
Show file tree

Hide file tree

Showing 4 changed files with 35 additions and 6 deletions.
diff --git a/data/resources/ui/pages/applications.ui b/data/resources/ui/pages/applications.ui
@@ -32,8 +32,8 @@
         </property>
         <child type="bottom">
           <object class="GtkBox">
-          <property name="orientation">vertical</property>
-          <child>
+            <property name="orientation">vertical</property>
+            <child>
               <object class="GtkRevealer" id="search_revealer">
                 <property name="transition_type">slide-up</property>
                 <child>
@@ -45,7 +45,11 @@
                     <property name="tightening-threshold">300</property>
                     <property name="maximum-size">400</property>
                     <child>
-                      <object class="GtkSearchEntry" id="search_entry"/>
+                      <object class="GtkSearchEntry" id="search_entry">
+                        <accessibility>
+                          <property name="label">Search applications</property>
+                        </accessibility>
+                      </object>
                     </child>
                   </object>
                 </child>
@@ -61,6 +65,9 @@
                 <child>
                   <object class="GtkToggleButton" id="search_button">
                     <property name="icon-name">search-symbolic</property>
+                    <accessibility>
+                      <property name="label">Toggle search field</property>
+                    </accessibility>
                     <style>
                       <class name="circular"/>
                     </style>
@@ -75,6 +82,9 @@
                       <object class="GtkButton" id="information_button">
                         <property name="icon-name">info-symbolic</property>
                         <property name="sensitive">false</property>
+                        <accessibility>
+                          <property name="label">Display application information</property>
+                        </accessibility>
                         <style>
                           <class name="circular"/>
                         </style>

diff --git a/data/resources/ui/pages/cpu.ui b/data/resources/ui/pages/cpu.ui
@@ -26,6 +26,9 @@
                         <property name="title" translatable="yes">Show Usages of Logical CPUs</property>
                         <child type="suffix">
                           <object class="GtkSwitch" id="logical_switch">
+                            <accessibility>
+                              <property name="label">Logical CPU switch</property>
+                            </accessibility>
                             <property name="valign">3</property>
                             <property name="sensitive">false</property>
                           </object>
@@ -62,6 +65,9 @@
                         </child>
                         <child>
                           <object class="GtkFlowBox" id="thread_box">
+                            <accessibility>
+                              <property name="label">CPU usage by logical processors</property>
+                            </accessibility>
                             <property name="row_spacing">6</property>
                             <property name="column_spacing">6</property>
                             <property name="homogeneous">true</property>

diff --git a/data/resources/ui/pages/processes.ui b/data/resources/ui/pages/processes.ui
@@ -32,8 +32,8 @@
         </property>
         <child type="bottom">
           <object class="GtkBox">
-          <property name="orientation">vertical</property>
-          <child>
+            <property name="orientation">vertical</property>
+            <child>
               <object class="GtkRevealer" id="search_revealer">
                 <property name="transition_type">slide-up</property>
                 <child>
@@ -45,7 +45,11 @@
                     <property name="tightening-threshold">300</property>
                     <property name="maximum-size">400</property>
                     <child>
-                      <object class="GtkSearchEntry" id="search_entry"/>
+                      <object class="GtkSearchEntry" id="search_entry">
+                        <accessibility>
+                          <property name="label">Search processes</property>
+                        </accessibility>
+                      </object>
                     </child>
                   </object>
                 </child>
@@ -61,6 +65,9 @@
                 <child>
                   <object class="GtkToggleButton" id="search_button">
                     <property name="icon-name">search-symbolic</property>
+                    <accessibility>
+                      <property name="label">Toggle search field</property>
+                    </accessibility>
                     <style>
                       <class name="circular"/>
                     </style>
@@ -75,6 +82,9 @@
                       <object class="GtkButton" id="information_button">
                         <property name="icon-name">info-symbolic</property>
                         <property name="sensitive">false</property>
+                        <accessibility>
+                          <property name="label">Show process information</property>
+                        </accessibility>
                         <style>
                           <class name="circular"/>
                         </style>

diff --git a/data/resources/ui/window.ui b/data/resources/ui/window.ui
@@ -42,6 +42,9 @@
                       <object class="GtkMenuButton">
                         <property name="menu-model">primary_menu</property>
                         <property name="icon-name">open-menu-symbolic</property>
+                        <accessibility>
+                          <property name="label">Open menu</property>
+                        </accessibility>
                       </object>
                     </child>
                   </object>