Skip to content
This repository has been archived by the owner on Dec 17, 2024. It is now read-only.

v047 upgrade #62

Draft
wants to merge 29 commits into
base: main
Choose a base branch
from
Draft

v047 upgrade #62

wants to merge 29 commits into from

Conversation

jhernandezb
Copy link
Collaborator

No description provided.

webmaster128
webmaster128 reviewed Feb 24, 2024
View reviewed changes
Copy link
Collaborator

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thank you! I added two commits and have some questions. Will test now

x/allocation/types/msg_claim_rewards_test.go
// assert.JSONEq(t, spec.exp, string(bz), "raw: %s", string(bz))
// })
// }
// }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can/should we re-enable that test?

app/ante/min_commission.go Show resolved Hide resolved
app/ante/min_deposit.go Show resolved Hide resolved
@webmaster128 webmaster128 mentioned this pull request Feb 25, 2024
Open
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@webmaster128 webmaster128 webmaster128 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhernandezb @webmaster128