agents: fix ZmqAgent asset JS API #192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the JS API to retrieve specific assets and send them to the Console, there was some code paths where the data would be pushed to the Zmq sockets from the JS thread instead of the agent thread. This is a serious bug that could cause unexpected breakage. Refactor the code to actually avoid the issue. Also took the opportunity to expand the ProfileCollector class to also support Heap Snapshots and use it in the agent.
santigimeno
force-pushed
the
santi/fix_zmq_js_api
branch
from
a4f115d
to
0cfed84
Compare
trevnorris
approved these changes
Oct 11, 2024
santigimeno
added a commit
that referenced
this pull request
Oct 14, 2024
When using the JS API to retrieve specific assets and send them to the Console, there was some code paths where the data would be pushed to the Zmq sockets from the JS thread instead of the agent thread. This is a serious bug that could cause unexpected breakage. Refactor the code to actually avoid the issue. Also took the opportunity to expand the ProfileCollector class to also support Heap Snapshots and use it in the agent. PR-URL: #192 Reviewed-By: Trevor Norris <[email protected]>
santigimeno
added a commit
that referenced
this pull request
Oct 16, 2024
When using the JS API to retrieve specific assets and send them to the Console, there was some code paths where the data would be pushed to the Zmq sockets from the JS thread instead of the agent thread. This is a serious bug that could cause unexpected breakage. Refactor the code to actually avoid the issue. Also took the opportunity to expand the ProfileCollector class to also support Heap Snapshots and use it in the agent. PR-URL: #192 Reviewed-By: Trevor Norris <[email protected]>
trevnorris
pushed a commit
that referenced
this pull request
Oct 29, 2024
When using the JS API to retrieve specific assets and send them to the Console, there was some code paths where the data would be pushed to the Zmq sockets from the JS thread instead of the agent thread. This is a serious bug that could cause unexpected breakage. Refactor the code to actually avoid the issue. Also took the opportunity to expand the ProfileCollector class to also support Heap Snapshots and use it in the agent. PR-URL: #192 Reviewed-By: Trevor Norris <[email protected]>
trevnorris
pushed a commit
that referenced
this pull request
Oct 30, 2024
When using the JS API to retrieve specific assets and send them to the Console, there was some code paths where the data would be pushed to the Zmq sockets from the JS thread instead of the agent thread. This is a serious bug that could cause unexpected breakage. Refactor the code to actually avoid the issue. Also took the opportunity to expand the ProfileCollector class to also support Heap Snapshots and use it in the agent. PR-URL: #192 Reviewed-By: Trevor Norris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the JS API to retrieve specific assets and send them to the Console, there was some code paths where the data would be pushed to the Zmq sockets from the JS thread instead of the agent thread. This is a serious bug that could cause unexpected breakage. Refactor the code to actually avoid the issue.
Also took the opportunity to expand the ProfileCollector class to also support Heap Snapshots and use it in the agent.