-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node v18.20.4 nsolid v5.3.4 release #190
Merged
trevnorris
merged 17 commits into
node-v18.x-nsolid-v5.x
from
node-v18.20.4-nsolid-v5.3.4-release
Oct 4, 2024
Merged
Node v18.20.4 nsolid v5.3.4 release #190
trevnorris
merged 17 commits into
node-v18.x-nsolid-v5.x
from
node-v18.20.4-nsolid-v5.3.4-release
Oct 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProfileCollector is a class that allows to start collecting profiles and report them to a callback function running in a specific uv_loop_t thread. PR-URL: #161 Reviewed-by: Trevor Norris <[email protected]>
PR-URL: #161 Reviewed-by: Trevor Norris <[email protected]>
PR-URL: #176 Reviewed-By: Santiago Gimeno <[email protected]>
This commit disables get-released-versions comparison as our base branch (node-vN.x-nsolid-vX.x) isn't the same as Node.js (main). So, the check expects that we are running into the `main` branch where all release commits go to (so the changelog) is up to date. PR-URL: #174 Reviewed-By: Santiago Gimeno <[email protected]>
PR-URL: #173 Reviewed-By: Santiago Gimeno <[email protected]>
PR-URL: #180 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-by: Trevor Norris <[email protected]>
santigimeno
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
PR-URL: #180 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-by: Trevor Norris <[email protected]>
PR-URL: #166 Fixes: #163 Reviewed-By: Santiago Gimeno <[email protected]>
PR-URL: #166 Fixes: #163 Reviewed-By: Santiago Gimeno <[email protected]>
PR-URL: #166 Fixes: #163 Reviewed-By: Santiago Gimeno <[email protected]>
PR-URL: #166 Fixes: #163 Reviewed-By: Santiago Gimeno <[email protected]>
PR-URL: #166 Fixes: #163 Reviewed-By: Santiago Gimeno <[email protected]>
PR-URL: #166 Fixes: #163 Reviewed-By: Santiago Gimeno <[email protected]>
PR-URL: #166 Fixes: #163 Reviewed-By: Santiago Gimeno <[email protected]>
PR-URL: #188 Reviewed-By: Santiago Gimeno <[email protected]>
trevnorris
force-pushed
the
node-v18.20.4-nsolid-v5.3.4-release
branch
from
October 4, 2024 19:09
e40a1b6
to
9fe792f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.