Initial patch for v22 support #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevnorris
force-pushed
the
trevnorris/v22-nsolid-patch
branch
4 times, most recently
from
fc0468a
to
7c661f5
Compare
This is a horrible solution, and we'll need a better one that reads in the fields that we need. But this will be the quickest for the time being and we'll patch later with a better fix.
Fix initialization of SumPointData and LastValuePointData by explicitly
setting value_ field after object creation.
The previous way of populating the class fields using {} caused a
compiler error. So instead explicitly assign the field after the class
has been created.
trevnorris
force-pushed
the
trevnorris/v22-nsolid-patch
branch
4 times, most recently
from
1303173
to
532a23b
Compare
Some tests use Node.js features that require c++20.
Something changed with npm, and now --ignore-scripts needs to be explicitly passed.
Added a quick fix so we can get v22 building. This test is broken by that, so skip it for now until a better fix can be implemented
trevnorris
force-pushed
the
trevnorris/v22-nsolid-patch
branch
from
1c17649
to
c58d375
Compare
Had to change how we read in the package.json path because of how Node.js now reads info using simdjson.
trevnorris
force-pushed
the
trevnorris/v22-nsolid-patch
branch
from
80802f1
to
4b06e43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We squashed all changes up to tag
node-v20.17.0-nsolid-v5.3.3and rebased it onto v22.9.0.