-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: add deps to process.versions #166
Conversation
Code looks good to me though I'd like we get to a decision on whether add this to |
It seems to add a |
While working on it, I've been thinking @santigimeno... I think believe that adding If we follow the |
Agreed. Let's keep it this way then |
One final comment: I would add |
dad7d4d
to
cd89c1b
Compare
I added grpc support in cd89c1b |
It should all good now @santigimeno |
PR-URL: #166 Fixes: #163 Reviewed-By: Santiago Gimeno <[email protected]>
PR-URL: #166 Fixes: #163 Reviewed-By: Santiago Gimeno <[email protected]>
PR-URL: #166 Fixes: #163 Reviewed-By: Santiago Gimeno <[email protected]>
PR-URL: #166 Fixes: #163 Reviewed-By: Santiago Gimeno <[email protected]>
PR-URL: #166 Fixes: #163 Reviewed-By: Santiago Gimeno <[email protected]>
PR-URL: #166 Fixes: #163 Reviewed-By: Santiago Gimeno <[email protected]>
PR-URL: #166 Fixes: #163 Reviewed-By: Santiago Gimeno <[email protected]>
Landed in cfd306f...0db40b4 |
1 similar comment
Landed in cfd306f...0db40b4 |
PR-URL: #166 Fixes: #163 Reviewed-By: Santiago Gimeno <[email protected]>
PR-URL: #166 Fixes: #163 Reviewed-By: Santiago Gimeno <[email protected]>
PR-URL: #166 Fixes: #163 Reviewed-By: Santiago Gimeno <[email protected]>
PR-URL: #166 Fixes: #163 Reviewed-By: Santiago Gimeno <[email protected]>
PR-URL: #166 Fixes: #163 Reviewed-By: Santiago Gimeno <[email protected]>
PR-URL: #166 Fixes: #163 Reviewed-By: Santiago Gimeno <[email protected]>
PR-URL: #166 Fixes: #163 Reviewed-By: Santiago Gimeno <[email protected]>
PR-URL: #166 Fixes: #163 Reviewed-By: Santiago Gimeno <[email protected]>
PR-URL: #166 Fixes: #163 Reviewed-By: Santiago Gimeno <[email protected]>
PR-URL: #166 Fixes: #163 Reviewed-By: Santiago Gimeno <[email protected]>
PR-URL: #166 Fixes: #163 Reviewed-By: Santiago Gimeno <[email protected]>
PR-URL: #166 Fixes: #163 Reviewed-By: Santiago Gimeno <[email protected]>
PR-URL: #166 Fixes: #163 Reviewed-By: Santiago Gimeno <[email protected]>
PR-URL: #166 Fixes: #163 Reviewed-By: Santiago Gimeno <[email protected]>
PR-URL: #166 Fixes: #163 Reviewed-By: Santiago Gimeno <[email protected]>
PR-URL: #166 Fixes: #163 Reviewed-By: Santiago Gimeno <[email protected]>
PR-URL: #166 Fixes: #163 Reviewed-By: Santiago Gimeno <[email protected]>
PR-URL: #166 Fixes: #163 Reviewed-By: Santiago Gimeno <[email protected]>
PR-URL: #166 Fixes: #163 Reviewed-By: Santiago Gimeno <[email protected]>
PR-URL: #166 Fixes: #163 Reviewed-By: Santiago Gimeno <[email protected]>
PR-URL: #166 Fixes: #163 Reviewed-By: Santiago Gimeno <[email protected]>
Fixes: #163
New dependency list:
process.versions
nor innsolid.info()
#163 correctly. Therefore, it doesn't seem to apply toprocess.versions
.grpc
.grpc
Note we are extracting the version directly in the deps/ folder. The Node.js sometimes create a
src/X_version.
and update it throughtools/updater.sh
. If you prefer I can do that, but it will require creating an updater for all of our dependency (I was planning to do it in a second PR).