Templating 2.0 #192
Draft
Templating 2.0 #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huy-nodeset
commented
Dec 19, 2024
Comment on lines
26
to
29
| tmpl, err := template.New(filepath.Base(t.Src)).Funcs(template.FuncMap{ | ||
| "GetValue": data.(*ServiceDataSource).GetValue, | ||
| "GetValueArray": data.(*ServiceDataSource).GetValueArray, | ||
| }).ParseFiles(t.Src) |
There was a problem hiding this comment.
Do not need this. The datatype should already be able to handle this.
huy-nodeset
commented
Dec 19, 2024
| Dst string | ||
| } | ||
|
|
||
| func (t AdapterTemplate) Write(data interface{}) error { |
There was a problem hiding this comment.
Can be re-used with adapter/service
huy-nodeset
commented
Dec 19, 2024
|
|
||
| // Struct to pass into the template engine containing all necessary data and methods for populating a template. | ||
| type MetadataDataSource struct { | ||
| CustomFields map[string]string |
There was a problem hiding this comment.
Don't need (TBD)
huy-nodeset
commented
Dec 19, 2024
|
|
||
| // Struct to pass into the template engine containing all necessary data and methods for populating a template. | ||
| type AdapterDataSource struct { | ||
| GetProjectName string |
There was a problem hiding this comment.
func() not string. Comes from hyperdrive itself
huy-nodeset
commented
Dec 19, 2024
Comment on lines
6
to
9
| ModuleConfigDir string | ||
| ModuleSecretFile string | ||
| ModuleLogDir string | ||
| ModuleJwtKeyFile string |
There was a problem hiding this comment.
probably will all be functions/methods.
Add Get to beginning and update spec
huy-nodeset
commented
Dec 19, 2024
Comment on lines
11
to
14
| ModuleConfigDir string | ||
| ModuleDataDir string | ||
| HyperdriveDaemonUrl string | ||
| HyperdriveJwtKeyFile string |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.