src: integrate ContextifyContext to cppgc #56522
Closed
+132
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #56522 +/- ##
=======================================
Coverage 89.20% 89.20%
=======================================
Files 662 662
Lines 191816 191818 +2
Branches 36926 36923 -3
=======================================
+ Hits 171102 171111 +9
+ Misses 13559 13555 -4
+ Partials 7155 7152 -3
|
joyeecheung
force-pushed
the
contextify-cppgc
branch
2 times, most recently
from
28b6b67 to
4cfe15f
Compare
github-actions
bot
removed
the
request-ci
joyeecheung
force-pushed
the
contextify-cppgc
branch
3 times, most recently
from
bcb919d to
a4ef690
Compare
joyeecheung
changed the title
|
After tracing the lifetime of ContextifyContexts a bit I realized that ContextifyContext does not even need to do any special cleanups, as the weak global handles in the context list would just become empty when the cycle involving Context/ContextifyContext is unreachable and will get purged sooner or later. So this no longer depend on #56534 |
joyeecheung
changed the title
legendecas
reviewed
Jan 13, 2025
jasnell
reviewed
Jan 13, 2025
joyeecheung
added
request-ci
legendecas
reviewed
Jan 13, 2025
|
That test seems to be doing something pretty unreliable - calling gc() in a loop until a context is collected. It should at least do that with setImmediate to free up the main thread, but we also already know from all the workarounds in test/common/gc that there is no reliable way to count on one particular object to be garbage collected (modulo taking a heap snapshot but that's a hack that I prefer not to abuse). We can see if using setImmediate helps and if not, try allocating a ton of contexts and see if any of them would be destroyed. If none of it helps stabilizing the test maybe we should just remove it or mark it as flaky... |
joyeecheung
force-pushed
the
contextify-cppgc
branch
from
d08c61f to
9667ff6
Compare
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This simplifies the memory management of ContextifyContext, making all references visible to V8. The destructors don't need to do anything because when the wrapper is going away, the context is already going away or otherwise it would've been holding the wrapper alive, so there's no need to reset the pointers in the context. Also, any global handles to the context would've been empty at this point, and the per-Environment context tracking code is capable of dealing with empty handles from contexts purged elsewhere. To this end, the context tracking code also purges empty handles from the list now, to prevent keeping too many empty handles around.
joyeecheung
force-pushed
the
contextify-cppgc
branch
2 times, most recently
from
8b366bd to
e67c128
Compare
github-actions
bot
removed
the
request-ci
jasnell
reviewed
Jan 15, 2025
| * The v8::TracedReference and the ContextEmbedderIndex::kContextifyContext | ||
| * slot in the context act as shortcuts from the node::ContextifyContext | ||
| * C++ object to the V8 context. | ||
| */ |
There was a problem hiding this comment.
Love the additional comment detail :-)
jasnell
reviewed
Jan 15, 2025
jasnell
approved these changes
Jan 15, 2025
github-actions
bot
removed
the
request-ci
legendecas
approved these changes
Jan 17, 2025
joyeecheung
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in cee63dc...74717cb |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jan 17, 2025
PR-URL: #56522 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jan 17, 2025
This simplifies the memory management of ContextifyContext, making all references visible to V8. The destructors don't need to do anything because when the wrapper is going away, the context is already going away or otherwise it would've been holding the wrapper alive, so there's no need to reset the pointers in the context. Also, any global handles to the context would've been empty at this point, and the per-Environment context tracking code is capable of dealing with empty handles from contexts purged elsewhere. To this end, the context tracking code also purges empty handles from the list now, to prevent keeping too many empty handles around. PR-URL: #56522 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the memory management of ContextifyContext,
making all references visible to V8.
The destructors don't need to do anything because when the wrapper is
going away, the context is already going away or otherwise it would've
been holding the wrapper alive, so there's no need to reset the
pointers in the context. Also, any global handles to the context
would've been empty at this point, and the per-Environment context
tracking code is capable of dealing with empty handles from contexts
purged elsewhere.
To this end, the context tracking code also purges empty handles
from the list now, to prevent keeping too many empty handles around.