tools: remove github reporter #56468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
meta
|
@cjihrig I'm not sure if I went overboard deleting stuff, lmk. |
Ceres6
commented
Jan 4, 2025
| @@ -317,7 +317,7 @@ def HasRun(self, output): | |||
| class ActionsAnnotationProgressIndicator(DotsProgressIndicator): | |||
| def AboutToRun(self, case): | |||
| case.additional_flags = case.additional_flags.copy() if hasattr(case, 'additional_flags') else [] | |||
| case.additional_flags.append('--test-reporter=./tools/github_reporter/index.js') | |||
| case.additional_flags.append('--test-reporter=./test/common/test-error-reporter.js') | |||
There was a problem hiding this comment.
This is actually not available yet, so we would need an intermediate value or waiting for #56438 and rebasing
There was a problem hiding this comment.
I don't mind waiting on the other PR, unless you want to move this fast
There was a problem hiding this comment.
Now that #56438 has landed, we can move forward with this.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56468 +/- ##
==========================================
- Coverage 89.20% 89.19% -0.01%
==========================================
Files 662 662
Lines 191802 191802
Branches 36914 36923 +9
==========================================
- Hits 171089 171079 -10
+ Misses 13563 13562 -1
- Partials 7150 7161 +11 |
cjihrig
approved these changes
Jan 4, 2025
| @@ -317,7 +317,7 @@ def HasRun(self, output): | |||
| class ActionsAnnotationProgressIndicator(DotsProgressIndicator): | |||
| def AboutToRun(self, case): | |||
| case.additional_flags = case.additional_flags.copy() if hasattr(case, 'additional_flags') else [] | |||
| case.additional_flags.append('--test-reporter=./tools/github_reporter/index.js') | |||
| case.additional_flags.append('--test-reporter=./test/common/test-error-reporter.js') | |||
benjamingr
approved these changes
Jan 5, 2025
atlowChemi
approved these changes
Jan 6, 2025
Merged
MoLow
approved these changes
Jan 7, 2025
github-actions
bot
removed
the
request-ci
Ceres6
force-pushed
the
chore/remove-github-reporter
branch
from
6e61361 to
03edfad
Compare
|
rebased |
github-actions
bot
removed
the
request-ci
cjihrig
approved these changes
Jan 14, 2025
cjihrig
added
author ready
aduh95
removed
the
commit-queue
|
Landed in afaa14b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the github reporter (with much verbose output) in favor of the error reporter in #56438