Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove trott from tsc email #125

Merged
merged 1 commit into from
Nov 21, 2018
Merged

remove trott from tsc email #125

merged 1 commit into from
Nov 21, 2018

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 21, 2018

No description provided.

mcollina
mcollina approved these changes Nov 21, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@targos
Copy link
Member

targos commented Nov 21, 2018

BTW what is this crypto-export address?

@Trott
Copy link
Member Author

Trott commented Nov 21, 2018

@targos I believe Michael Dawson added it when the Foundation had to fill out some sort of paperwork or something for U.S. law involving exporting crypto (which used to be and perhaps still is regulated as a munition in the U.S., if you can believe that). I believe we needed to supply the U.S. government with an email address in case they had questions about Node.js exporting cryptography out of the United States. I'm probably messing up details here, but the upshot is that it was a mostly bureaucratic thing and it was decided to make it the TSC + the executive director of the Foundation.

Oh, here it is: #104

mhdawson
mhdawson approved these changes Nov 21, 2018
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson merged commit d2c7827 into nodejs:master Nov 21, 2018
@mhdawson
Copy link
Member

deployed

Johnhvy added a commit to Johnhvy/NodeJS-Email that referenced this pull request Jul 16, 2024
@Johnhvy
remove trott from tsc email (#125)
f30872c 
PR-URL: nodejs/email#125
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@targos targos targos approved these changes

@addaleax addaleax addaleax approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @targos @mhdawson @mcollina @addaleax