-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lookup: add astro #1055
base: main
Are you sure you want to change the base?
lookup: add astro #1055
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding Astro ❤️
Before merging I wanna make sure it's not flaky and everything working correctly |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1055 +/- ##
=======================================
Coverage 96.35% 96.35%
=======================================
Files 29 29
Lines 2192 2192
=======================================
Hits 2112 2112
Misses 80 80 ☔ View full report in Codecov by Sentry. |
Update lookup.json
Checklist
npm test
passeshere
Ref: #1054
Hard Requirements
npm install && npm test
or (yarn install && yarn test
or
pnpm install && pnpm test
) using the tarballdownloaded from the Github tag mentioned above - don't think it's relevant anymore as you have
scripts
Soft Requirements
At least one of:
OR - Yes, this is the first big project that uses
node:test
Run this branch on CITGM to make sure I'm not introducing flaky tests:
TODO