Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lookup: add astro #1055

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

lookup: add astro #1055

wants to merge 13 commits into from

Conversation

rluvaton
Copy link
Member

@rluvaton rluvaton commented Apr 5, 2024

Checklist
  • npm test passes
  • documentation is changed or added
  • contribution guidelines followed
    here

Ref: #1054

Hard Requirements

  • Module source code must be on Github.
  • Published versions must include a tag on Github
  • The test process must be executable with only the commands
    npm install && npm test or (yarn install && yarn test
    or pnpm install && pnpm test) using the tarball
    downloaded from the Github tag mentioned above - don't think it's relevant anymore as you have scripts
  • The tests pass on supported major release lines - Tested locally but wanna test that also on our CI
  • The maintainers of the module remain responsive when there are problems
  • At least one module maintainer must be added to the lookup maintainers field

Soft Requirements

At least one of:

  • The module must be actively used by the community OR
  • The module must be heavily depended on OR
  • The module must cover unique portions of our API OR
  • The module fits into a key category (e.g. Testing, Streams, Monitoring, etc.)
    OR - Yes, this is the first big project that uses node:test
  • The module is under the Node.js foundation Github org OR
  • The module is identified as an important module by a Node.js Working Group

Run this branch on CITGM to make sure I'm not introducing flaky tests:

TODO

  • update astro test:citgm command to run only the astro package tests as they take too long (more than 30m)
  • Only build the package that testing

Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding Astro ❤️

@rluvaton
Copy link
Member Author

rluvaton commented Apr 6, 2024

Before merging I wanna make sure it's not flaky and everything working correctly

@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.35%. Comparing base (12e6902) to head (01e904e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1055   +/-   ##
=======================================
  Coverage   96.35%   96.35%           
=======================================
  Files          29       29           
  Lines        2192     2192           
=======================================
  Hits         2112     2112           
  Misses         80       80           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants