Skip to content

Commit

Permalink
fix packing uses the wrong qt (#164)
Browse files Browse the repository at this point in the history
* fix packing uses the wrong qt

see #105 (comment) for more details

* fix PATH separator mistake
  • Loading branch information
liudonghua123 authored Jan 4, 2022
1 parent 4402228 commit 5e4eef1
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/win32/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ function getAllNodeAddons(dirPath: string) {

const runWinDeployQt = async (appName: string, buildDir: string) => {
const winDeployQtBin = path.resolve(qtHome, "bin", "windeployqt.exe");
// insert qtHome/bin into the PATH for windeployqt work correctly
process.env.PATH=`${path.resolve(qtHome, "bin")};${process.env.PATH}`;

const distPath = path.resolve(buildDir, "dist");
const allAddons = getAllNodeAddons(distPath);
Expand All @@ -50,6 +52,7 @@ const runWinDeployQt = async (appName: string, buildDir: string) => {
],
{
cwd: buildDir,
env: process.env,
}
);

Expand Down

0 comments on commit 5e4eef1

Please sign in to comment.