Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cube rendering #41

Merged
merged 6 commits into from
Dec 27, 2024
Merged

Conversation

TibiNonEst
Copy link
Contributor

@TibiNonEst TibiNonEst commented Feb 13, 2022

The goal of this pr is to add general improvements to the cube head rendering feature.

  • Add head overlay option to render
  • Center render in png
  • Add depth shading
  • Anti-alias hard edges

@TibiNonEst
Copy link
Contributor Author

Currently, the branch renders the overlay textures directly on top of the cube, meaning it looks like one contiguous texture. While this is good for 2D renders, it may be more desirable to render them slightly offset from the head like how Visage does.

@TibiNonEst TibiNonEst force-pushed the improved-cube-rendering branch from 4f2a641 to 947df0c Compare February 14, 2022 19:39
@TibiNonEst
Copy link
Contributor Author

TibiNonEst commented Feb 15, 2022

The imageproc API doesn't add any way to anti-alias the image during the warp transformation, I'll look into other ways of implementing this.

@TibiNonEst
Copy link
Contributor Author

TibiNonEst commented Feb 16, 2022

Once this is done, #4 should be fairly straightforward which is nice, just gotta implement anti-aliasing first. I have an idea of how to do that but it would probably require no longer using imageproc and putting manual perspective warp code into utils.rs, but I'll see what works best without being overly jank.

@bribes
Copy link
Contributor

bribes commented Mar 21, 2022

Once this is done, #4 should be fairly straightforward which is nice, just gotta implement anti-aliasing first. I have an idea of how to do that but it would probably require no longer using imageproc and putting manual perspective warp code into utils.rs, but I'll see what works best without being overly jank.

Nicee, excited for this because I want to be able to use a maintained alternative to Visage for 3D skins and also because it this should also fix the old skin compatibility issues I'm having with Visage.

@TibiNonEst TibiNonEst closed this Apr 6, 2022
@TibiNonEst
Copy link
Contributor Author

Tfw I'm trying to comment and click the wrong button.

@TibiNonEst TibiNonEst reopened this Apr 6, 2022
@TibiNonEst
Copy link
Contributor Author

Anyway, I don't really know a good way of antialiasing cube renders while keeping the speed that imageproc provides. I think I might be able to skew it based on Minotar's imgd code but I would ideally like to continue using projections to do this so I really don't know.

@bribes
Copy link
Contributor

bribes commented Apr 6, 2022

Anyway, I don't really know a good way of antialiasing cube renders while keeping the speed that imageproc provides. I think I might be able to skew it based on Minotar's imgd code but I would ideally like to continue using projections to do this so I really don't know.

Rip

@s-aditya-k
Copy link

this hasn't seem to be touched since april - maybe its time to split the antialiasing into a seperate PR and merge what's ready?

@Cherry
Copy link
Member

Cherry commented Mar 3, 2024

Heey @TibiNonEst, thanks for this PR, and sorry for the review time! Is this something you're still interested in working on?

@yutotakano
Copy link

Is there anything on this PR that needs work other than the anti-aliasing? Seems good enough to merge to me.

@Cherry
Copy link
Member

Cherry commented Dec 22, 2024

I've updated this for the most recent repo changes @TibiNonEst and would love your thoughts.

@Cherry Cherry marked this pull request as ready for review December 27, 2024 14:34
@Cherry
Copy link
Member

Cherry commented Dec 27, 2024

I'm going to go ahead and merge this. If we want to followup with antialiasing, that can be done later. Thanks so much for the PR!

@Cherry Cherry merged commit 1e7c01d into nodecraft:master Dec 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants