-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve cube rendering #41
Conversation
Currently, the branch renders the overlay textures directly on top of the cube, meaning it looks like one contiguous texture. While this is good for 2D renders, it may be more desirable to render them slightly offset from the head like how Visage does. |
4f2a641
to
947df0c
Compare
The |
Once this is done, #4 should be fairly straightforward which is nice, just gotta implement anti-aliasing first. I have an idea of how to do that but it would probably require no longer using |
Nicee, excited for this because I want to be able to use a maintained alternative to Visage for 3D skins and also because it this should also fix the old skin compatibility issues I'm having with Visage. |
Tfw I'm trying to comment and click the wrong button. |
Anyway, I don't really know a good way of antialiasing cube renders while keeping the speed that |
Rip |
this hasn't seem to be touched since april - maybe its time to split the antialiasing into a seperate PR and merge what's ready? |
Heey @TibiNonEst, thanks for this PR, and sorry for the review time! Is this something you're still interested in working on? |
Is there anything on this PR that needs work other than the anti-aliasing? Seems good enough to merge to me. |
I've updated this for the most recent repo changes @TibiNonEst and would love your thoughts. |
I'm going to go ahead and merge this. If we want to followup with antialiasing, that can be done later. Thanks so much for the PR! |
The goal of this pr is to add general improvements to the cube head rendering feature.