Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid duplicate default arg descriptions when using ArgumentDefaultsHelpFormatter and BooleanOptionalAction #178

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid duplicate default arg descriptions when using ArgumentDefaultsHelpFormatter and BooleanOptionalAction #178

wants to merge 1 commit into from

Conversation

pes10k
Copy link

@pes10k pes10k commented Dec 3, 2024

fixes #177

@pes10k pes10k changed the title avoid duplicate default arg descriptions when using ArgumentDefaultsHelpFormatter and BooleanOptionalAction Avoid duplicate default arg descriptions when using ArgumentDefaultsHelpFormatter and BooleanOptionalAction Dec 3, 2024
@pes10k pes10k force-pushed the avoid-duplicate-default-descriptions branch 2 times, most recently from 3921105 to 470e8c1 Compare December 3, 2024 18:03
@pes10k
have helpers indicate if they added a default arg desc, and use that …
1f9bd44 
…to avoid duplciating it in ArgumentDefaultsHelpFormatter, fixes nodeca#177
@pes10k pes10k force-pushed the avoid-duplicate-default-descriptions branch from 470e8c1 to 1f9bd44 Compare December 3, 2024 18:04
@pes10k
Copy link
Author

pes10k commented Dec 3, 2024

Thanks for the fantastic library nodeca! This is my my first time submitting a PR for your project. I tried to avoid any obvious issues with npm run lint and npm run test, and added a new test.

If theres anything else i can do to help, please let me know

@pes10k
Copy link
Author

pes10k commented Dec 15, 2024

ping on this @rlidwka :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@pes10k