Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update oauth.js #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update oauth.js #22

wants to merge 1 commit into from

Conversation

jaywu0128
Copy link

修复非静默授权bug,成功获取用户信息后,err会返回ok

@@ -368,7 +368,7 @@ OAuth.prototype._verifyToken = function (openid, accessToken, callback) {
OAuth.prototype.getUserByCode = function (code, callback) {
var that = this;
this.getAccessToken(code, function (err, result) {
if (err) {
if (err&&err!='ok') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. coding style 保持下。
  2. 能否提供个单元测试

@coveralls
Copy link

coveralls commented Aug 8, 2016

Coverage Status

Coverage remained the same at 86.239% when pulling a150b1c on jaywu0128:patch-1 into 4efaec2 on node-webot:master.

@JacksonTian
Copy link
Member

ping @jaywu0128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants