Document how to avoid assertions causing test timeout (issue #45) #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also see the previous commit and #45.
|
|
mrubli
changed the title
|
@knolleary Would you mind taking a look at this PR? After your recent fix for #48 (much appreciated, btw!) I wanted to improve the documentation on testing with the Catch node a bit and create a PR to resolve the long-standing #18 (basically adding to the existing doc with an example). Such documentation would have helped us greatly a couple of days ago. I was just hoping to resolve this PR first before I get started on a new one. |
|
Hi @mrubli sorry for overlooking this one. All looks good to me. |
|
No worries. Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This documents #45 in the README and updates the example accordingly.